Fix pad border highlight in GL mode#21911
Open
linev wants to merge 1 commit intoroot-project:masterfrom
Open
Conversation
Was drawn before at the very end and therefore render order was not correct. If active pad was hidden by other pad border was drawn on the top anyway.
bellenot
approved these changes
Apr 14, 2026
Member
bellenot
left a comment
bellenot
left a comment
There was a problem hiding this comment.
LGTM (at least it works with your example on Windows)
| // | ||
| TVirtualPadPainter *fPainter; ///<! Canvas (pad) painter. | ||
|
|
||
| TVirtualPad *fHilightPadBorder = nullptr; ///<! pad which border will be hilghlighrt when paint canvas |
Collaborator
There was a problem hiding this comment.
Suggested change
| TVirtualPad *fHilightPadBorder = nullptr; ///<! pad which border will be hilghlighrt when paint canvas | |
| TVirtualPad *fHilightPadBorder = nullptr; ///<! pad whose border will be highlighted when paint canvas |
Test Results 22 files 22 suites 3d 2h 16m 30s ⏱️ Results for commit 80a893b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was drawn before at the very end and therefore render order was not correct. If active pad was hidden by other pad border was drawn on the top anyway.
Can be generalized also for normal painting later