[ftgl] Download instead of bundle and bump from 2.1.2 to 2.4, and use CMake target#21898
Open
ferdymercury wants to merge 2 commits intoroot-project:masterfrom
Open
[ftgl] Download instead of bundle and bump from 2.1.2 to 2.4, and use CMake target#21898ferdymercury wants to merge 2 commits intoroot-project:masterfrom
ferdymercury wants to merge 2 commits intoroot-project:masterfrom
Conversation
ferdymercury
changed the title
ferdymercury
force-pushed
the
bftgl
branch
3 times, most recently
from
04392d9 to
20d44ae
Compare
ferdymercury
force-pushed
the
bftgl
branch
4 times, most recently
from
eb09a22 to
5c9b702
Compare
ferdymercury
added
the
skip code analysis
Test Results 22 files 22 suites 3d 7h 2m 15s ⏱️ For more details on these failures, see this check. Results for commit e8ddf11. ♻️ This comment has been updated with latest results. |
ferdymercury
commented
Apr 13, 2026
ferdymercury
commented
Apr 13, 2026
ferdymercury
commented
Apr 13, 2026
| @@ -0,0 +1,39 @@ | |||
| diff --git a/src/FTContour.cpp b/src/FTContour.cpp | |||
Collaborator
Author
There was a problem hiding this comment.
@silverweed I got this patch from https://github.com/luadebug/xmake-repo/blob/66321835cb5e940f5997c10de515d50e91aaac47/packages/f/ftgl/patches/2.4.0/fix-type-error.patch
maybe you know of a good way to tune it to include your probably more accurate fixes from a028d13
ferdymercury
commented
Apr 13, 2026
ferdymercury
commented
Apr 13, 2026
ferdymercury
commented
Apr 13, 2026
[cmake] fix win32 failures
… CMake target
[ftgl] try to fix win32 find-package error
[ftgl] patch to fix win32 compilation error
[ftgl] fix win32 static flag
Attempt to fix
Creating library C:/ROOT-CI/build/lib/libRGL.lib and object C:/ROOT-CI/build/lib/libRGL.exp
TGLFontManager.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: void __thiscall FTFont::BBox(char const *,float &,float &,float &,float &,float &,float &)" (__imp_?BBox@FTFont@@QAEXPBDAAM11111@Z) referenced in function "private: void __thiscall TGLFont::RenderHelper<char>(char const *,double,double,double,double)const " (??$RenderHelper@D@TGLFont@@ABEXPBDNNNN@Z) [C:\ROOT-CI\build\graf3d\gl\RGL.vcxproj]
TGLText.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) public: void __thiscall FTFont::BBox(char const *,float &,float &,float &,float &,float &,float &)" (__imp_?BBox@FTFont@@QAEXPBDAAM11111@Z) [C:\ROOT-CI\build\graf3d\gl\RGL.vcxproj]
TGLFontManager.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: void __thiscall FTFont::BBox(wchar_t const *,float &,float &,float &,float &,float &,float &)" (__imp_?BBox@FTFont@@QAEXPB_WAAM11111@Z) referenced in function "private: void __thiscall TGLFont::RenderHelper<wchar_t>(wchar_t const *,double,double,double,double)const " (??$RenderHelper@_W@TGLFont@@ABEXPB_WNNNN@Z) [C:\ROOT-CI\build\graf3d\gl\RGL.vcxproj]
C:\ROOT-CI\build\bin\libRGL.dll : fatal error LNK1120: 2 unresolved externals [C:\ROOT-CI\build\graf3d\gl\RGL.vcxproj]
because FLAG not propagated, they only use local add_definitions (CMake 2.8) rather than target-based
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.