Skip to content
Open
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
207 changes: 0 additions & 207 deletions math/genvector/test/Makefile

This file was deleted.

114 changes: 0 additions & 114 deletions math/mathcore/test/fit/Makefile

This file was deleted.

2 changes: 2 additions & 0 deletions math/smatrix/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -57,3 +57,5 @@ ROOT_GENERATE_DICTIONARY(G__Smatrix32
Core
MathCore
)

ROOT_ADD_TEST_SUBDIRECTORY(test)
45 changes: 45 additions & 0 deletions math/smatrix/test/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
# Copyright (C) 1995-2026, Rene Brun and Fons Rademakers.
# All rights reserved.
#
# For the licensing terms see $ROOTSYS/LICENSE.
# For the list of contributors see $ROOTSYS/README/CREDITS.

# @author Danilo Piparo CERN

project(smatrix-tests)

set(Libraries Core RIO Tree Rint Matrix MathCore Hist)

set(TestSource
testSMatrix.cxx
testOperations.cxx
testKalman.cxx
testIO.cxx
testInversion.cxx
stressOperations.cxx
stressKalman.cxx)


ROOT_GENERATE_DICTIONARY(TrackDict Track.h LINKDEF TrackLinkDef.h OPTIONS -inlineInputHeader)
Comment thread
ferdymercury marked this conversation as resolved.

#---Build and add all the defined test in the list---------------
foreach(file ${TestSource})
get_filename_component(testname ${file} NAME_WE)
if (testname STREQUAL "testIO")
ROOT_EXECUTABLE(${testname} ${file} TrackDict.cxx LIBRARIES ${Libraries})
else()
ROOT_EXECUTABLE(${testname} ${file} LIBRARIES ${Libraries})
endif()
target_include_directories(${testname} PRIVATE ./)
if (CLHEPBASE)
Comment thread
ferdymercury marked this conversation as resolved.
Outdated
target_include_directories(${testname} PRIVATE ${CLHEPBASE})
target_compile_definitions(${testname} PRIVATE HAVE_CLHEP)
if (WIN32)
target_link_libraries(${testname} PRIVATE "${CLHEPBASE}/lib/CLHEP.lib")
else()
target_link_libraries(${testname} PRIVATE "CLHEP" "m")
target_link_directories(${testname} PRIVATE "${CLHEPBASE}/lib")
endif()
endif()
Comment thread
linev marked this conversation as resolved.
Outdated
ROOT_ADD_TEST(smatrix-${testname} COMMAND ${testname} LABELS ${${testname}_LABELS})
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two ROOT files in the directory which were generated by the tests.
One should try use these files for tests.
Most probably one need to make custom ROOT_ADD_TEST commands providing file name as argument

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean checking that the result generated by the test is compatible with that reference?

https://github.com/ferdymercury/root/blob/5ce524b96321eb747d38c3c7358980ee2ef0976d/math/smatrix/test/testOperations.cxx#L776

they get recreated at every run. so i guess that reference was done on an old SLC3 and gcc3

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can extend testOperations.cxx and try to read old files as well.

endforeach()
Loading
Loading