[WIP][RF] Remove all code related to constant term optimization#21831
Draft
guitargeek wants to merge 1 commit intoroot-project:masterfrom
Draft
[WIP][RF] Remove all code related to constant term optimization#21831guitargeek wants to merge 1 commit intoroot-project:masterfrom
guitargeek wants to merge 1 commit intoroot-project:masterfrom
Conversation
guitargeek
force-pushed
the
const_optimize_removal
branch
from
36493d2 to
06fcbf7
Compare
Test Results 22 files 22 suites 3d 5h 38m 53s ⏱️ For more details on these failures, see this check. Results for commit 54f6ce7. ♻️ This comment has been updated with latest results. |
This is one of the most complicated aspects of RooFit, which was deprecated in 6.40 and scheduled for removal in 6.42. It amounted to over 1 percent of the RooFitCore source code, and is now superseeded by the vectorized evaluation backend, which does the caching of vector buffers transparently in the RooFit evaluator.
guitargeek
force-pushed
the
const_optimize_removal
branch
from
06fcbf7 to
54f6ce7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one of the most complicated aspects of RooFit, which was deprecated in 6.40 and scheduled for removal in 6.42.
It amounted to over 1 percent of the RooFitCore source code, and is now superseeded by the vectorized evaluation backend, which does the caching of vector buffers transparently in the RooFit evaluator.
Follows up on 7e94aef, where the feature got deprecated.
Do not merge yet! This is for the 6.42 development cycle. But since this is a pretty massive change, I wanted to see before what would happen.