Skip to content

Fix install phases for migrated and legacy dev packages #3793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JasonGross merged 5 commits into from
Jul 31, 2026
Merged

Fix install phases for migrated and legacy dev packages #3793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a4ab9ee
Run migrated contrib installs in opam install phase
JasonGross Jul 28, 2026
3d02691
Run dev package installation in opam install phase
JasonGross Jul 28, 2026
d60380d
Run BDDs and SMC installation in opam install phase
JasonGross Jul 28, 2026
698e692
Fix coq-mathcomp-grobner.dev lint error and restore Makefile generation
JasonGross Jul 30, 2026
d96f355
Track upstream master in coq-mathcomp-grobner.dev
JasonGross Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extra-dev/packages/coq-additions/coq-additions.dev/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ license: "LGPL 2"
build: [
["coq_makefile" "-f" "Make" "-o" "Makefile"]
[make "-j%{jobs}%"]
[make "install"]
]
install: [make "install"]
remove: ["rm" "-R" "%{lib}%/coq/user-contrib/Additions"]
depends: [
"ocaml"
Expand Down
2 changes: 1 addition & 1 deletion extra-dev/packages/coq-bdds/coq-bdds.dev/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ build: [
["coq_makefile" "-f" "Make" "-o" "Makefile"]
# [make "-j%{jobs}%"]
[make]
[make "install"]
]
install: [make "install"]
remove: ["rm" "-R" "%{lib}%/coq/user-contrib/BDDs"]
depends: [
"ocaml"
Expand Down
2 changes: 1 addition & 1 deletion extra-dev/packages/coq-dictionaries/coq-dictionaries.dev/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ license: "LGPL 2"
build: [
["coq_makefile" "-f" "Make" "-o" "Makefile"]
[make "-j%{jobs}%"]
[make "install"]
]
install: [make "install"]
remove: ["rm" "-R" "%{lib}%/coq/user-contrib/Dictionaries"]
depends: [
"ocaml"
Expand Down
2 changes: 1 addition & 1 deletion extra-dev/packages/coq-euler-formula/coq-euler-formula.dev/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ license: "LGPL"
build: [
["coq_makefile" "-f" "Make" "-o" "Makefile"]
[make "-j%{jobs}%"]
[make "install"]
]
install: [make "install"]
remove: ["rm" "-R" "%{lib}%/coq/user-contrib/EulerFormula"]
depends: [
"ocaml"
Expand Down
2 changes: 1 addition & 1 deletion extra-dev/packages/coq-float/coq-float.dev/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ license: "LGPL 2"
build: [
["coq_makefile" "-f" "Make" "-o" "Makefile"]
[make "-j%{jobs}%"]
[make "install"]
]
install: [make "install"]
remove: ["rm" "-R" "%{lib}%/coq/user-contrib/Float"]
depends: [
"ocaml"
Expand Down
2 changes: 1 addition & 1 deletion extra-dev/packages/coq-hardware/coq-hardware.dev/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ license: "LGPL 2"
build: [
["coq_makefile" "-f" "Make" "-o" "Makefile"]
[make "-j%{jobs}%"]
[make "install"]
]
install: [make "install"]
remove: ["rm" "-R" "%{lib}%/coq/user-contrib/Hardware"]
depends: [
"ocaml"
Expand Down
2 changes: 1 addition & 1 deletion extra-dev/packages/coq-ieee754/coq-ieee754.dev/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ license: "LGPL 2"
build: [
["coq_makefile" "-f" "Make" "-o" "Makefile"]
[make "-j%{jobs}%"]
[make "install"]
]
install: [make "install"]
remove: ["rm" "-R" "%{lib}%/coq/user-contrib/IEEE754"]
depends: [
"ocaml"
Expand Down
2 changes: 1 addition & 1 deletion extra-dev/packages/coq-int-map/coq-int-map.dev/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ license: "LGPL 2"
build: [
["coq_makefile" "-f" "Make" "-o" "Makefile"]
[make "-j%{jobs}%"]
[make "install"]
]
install: [make "install"]
remove: ["rm" "-R" "%{lib}%/coq/user-contrib/IntMap"]
depends: [
"ocaml"
Expand Down
28 changes: 14 additions & 14 deletions extra-dev/packages/coq-mathcomp-grobner/coq-mathcomp-grobner.dev/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,26 @@
opam-version: "2.0"
maintainer: "Laurent.Thery@inria.fr"
homepage: "https://github.com/thery/grobner"
dev-repo: "git+https://github.com/thery/grobner.git"
bug-reports: "https://github.com/thery/grobner/issues"
license: "MIT"
build: [
["./configure.sh"]
[make "-j%{jobs}%"]
[make "install"]
authors: [
"Laurent Théry"
]
build: [make "-j%{jobs}%"]
install: [make "install"]
remove: [
["rm" "-R" "%{lib}%/coq/user-contrib/mathcomp/contrib/grobner"]
["sh" "-c" "rmdir %{lib}%/coq/user-contrib/mathcomp/contrib || true"]
]
depends: [
"ocaml"
"coq" {>= "8.5"}
"coq-mathcomp-ssreflect" {>= "1.6"}
"coq-mathcomp-algebra"
"coq-mathcomp-multinomials" {= "1.6.dev"}
"coq" {>= "9.0" | = "dev"}
"coq-mathcomp-ssreflect" {>= "2.5.0"}
"coq-mathcomp-algebra" {>= "2.5.0"}
"coq-mathcomp-multinomials" {>= "2.4.0"}
]
synopsis: "# grobner"
synopsis: "Grobner basis"
description: """
A fornalisation of Grobner basis in ssreflect.
It contains one file
Expand All @@ -28,15 +29,15 @@ grobner.v

It defines.

From mathcomp Require Import all_ssreflect all_algebra.
From SsrMultinomials Require Import ssrcomplements poset freeg mpoly.
From mathcomp Require Import all_boot all_algebra.
From mathcomp Require Import ssrcomplements freeg mpoly.
From mathcomp.contrib.grobner Require Import grobner.

(* p belongs to the ideal generated by L *)

Check ideal.

ideal =
ideal =
fun (R : ringType) (n : nat) (L : seq {mpoly R[n]}) (p : {mpoly R[n]})
=>
exists t, p = \\sum_(i < size L) t`_i * L`_i
Expand All @@ -51,6 +52,5 @@ idealfP
(l : seq {mpoly R[n]}),
reflect (ideal l p) (idealf l p)"""
url {
src: "https://github.com/thery/grobner/archive/v1.0.1.zip"
checksum: "md5=ee88f5010096f45a5be120de58910913"
src: "git+https://github.com/thery/grobner.git#master"
}
2 changes: 1 addition & 1 deletion extra-dev/packages/coq-mod-red/coq-mod-red.dev/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ license: "GNU Lesser General Public License"
build: [
["coq_makefile" "-f" "Make" "-o" "Makefile"]
[make "-j%{jobs}%"]
[make "install"]
]
install: [make "install"]
remove: ["rm" "-R" "%{lib}%/coq/user-contrib/ModRed"]
depends: [
"ocaml"
Expand Down
2 changes: 1 addition & 1 deletion extra-dev/packages/coq-qarith/coq-qarith.dev/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ license: "LGPL 2"
build: [
["coq_makefile" "-f" "Make" "-o" "Makefile"]
[make "-j%{jobs}%"]
[make "install"]
]
install: [make "install"]
remove: ["rm" "-R" "%{lib}%/coq/user-contrib/QArith"]
depends: [
"ocaml"
Expand Down
2 changes: 1 addition & 1 deletion extra-dev/packages/coq-smc/coq-smc.dev/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ license: "LGPL 2"
build: [
["coq_makefile" "-f" "Make" "-o" "Makefile"]
[make "-j%{jobs}%"]
[make "install"]
]
install: [make "install"]
remove: ["rm" "-R" "%{lib}%/coq/user-contrib/SMC"]
depends: [
"ocaml"
Expand Down
2 changes: 1 addition & 1 deletion extra-dev/packages/coq-zchinese/coq-zchinese.dev/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ license: "Proprietary"
build: [
["coq_makefile" "-f" "Make" "-o" "Makefile"]
[make "-j%{jobs}%"]
[make "install"]
]
install: [make "install"]
remove: ["rm" "-R" "%{lib}%/coq/user-contrib/ZChinese"]
depends: [
"ocaml"
Expand Down
2 changes: 1 addition & 1 deletion extra-dev/packages/coq-zsearch-trees/coq-zsearch-trees.dev/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ license: "LGPL 2"
build: [
["coq_makefile" "-f" "Make" "-o" "Makefile"]
[make "-j%{jobs}%"]
[make "install"]
]
install: [make "install"]
remove: ["rm" "-R" "%{lib}%/coq/user-contrib/ZSearchTrees"]
depends: [
"ocaml"
Expand Down
Loading