Remove the last call to Gecode::Gist - #4
Open
pierrewillenbrockdfki wants to merge 2 commits into
Open
Conversation
Gist is the Gecode Interactive Search Tool, using Qt to display a GUI.
Collaborator
Author
|
@2maz judging by the commented calls to Gecode::Gist, there seems to have been some effort to remove it already. Also, i cannot see how an interactive search tool would have a place in the non-gui library bits. I am planning to remove Gecode::Gist and Gecode::Flatzinc from knowledge_reasoning/moreorg(where none of them is used either), so the reference here has to be removed first. I'll be on vacation for a week and merge this afterwards if there are no problems/comments/it is not already merged. |
Member
|
Fine with me. Although I suggest to remove the reference then entirely. Not just commenting. |
Collaborator
Author
|
Looks like the runs-on: ubuntu-18.04 has finally been removed. I'll do another PR that fixes that, merge that here and then things should be back to working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gist is the Gecode Interactive Search Tool, using Qt to display a GUI.
This means the templ library depends on the qt version gecode is built with if Gecode::Gist is referenced anywhere, which poses a problem when it is to be used with a different qt version.