Skip to content

perf(eval): avoid full-coordinate overlap temporaries #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JESUSROYETH wants to merge 1 commit into
base: develop
Choose a base branch
from
+13 −8
Open

perf(eval): avoid full-coordinate overlap temporaries #577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/trackers/eval/box.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,14 +161,19 @@ def _calculate_box_ious(
boxes1 = np.asarray(boxes1, dtype=np.float64)
boxes2 = np.asarray(boxes2, dtype=np.float64)

# Calculate intersection coordinates
# boxes1: (N, 4), boxes2: (M, 4) -> broadcasting to (N, M, 4)
min_ = np.minimum(boxes1[:, np.newaxis, :], boxes2[np.newaxis, :, :])
max_ = np.maximum(boxes1[:, np.newaxis, :], boxes2[np.newaxis, :, :])

# Intersection: max of left edges to min of right edges
# min_[..., 2] is min of x1 values, max_[..., 0] is max of x0 values
intersection = np.maximum(min_[..., 2] - max_[..., 0], 0) * np.maximum(min_[..., 3] - max_[..., 1], 0)
# Calculate intersection dimensions by broadcasting each coordinate plane
# directly, without full (N, M, 4) arrays
intersection_width = np.maximum(
np.minimum(boxes1[:, np.newaxis, 2], boxes2[np.newaxis, :, 2])
- np.maximum(boxes1[:, np.newaxis, 0], boxes2[np.newaxis, :, 0]),
0,
)
intersection_height = np.maximum(
np.minimum(boxes1[:, np.newaxis, 3], boxes2[np.newaxis, :, 3])
- np.maximum(boxes1[:, np.newaxis, 1], boxes2[np.newaxis, :, 1]),
0,
)
intersection = intersection_width * intersection_height

# Area of boxes1
area1 = (boxes1[..., 2] - boxes1[..., 0]) * (boxes1[..., 3] - boxes1[..., 1])
Expand Down
Loading