Add How to Tell Objects Apart with ReID notebook - #450
Open
AlexBodner wants to merge 15 commits into
Open
Conversation
Copy the reid package eval_reid tutorial into Roboflow notebooks with banner, relative paths, and setup aligned for a first-release showcase. Co-authored-by: Cursor <cursoragent@cursor.com>
Showcase the reid package with Market/MSMT metrics and SportsMOT ranking visuals, and register it in the notebooks table. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Use trackers.roboflow.com and reid.roboflow.com instead of GitHub blob paths where docs exist. Co-authored-by: Cursor <cursoragent@cursor.com>
This reverts commit 33c8f5d.
PyPI reid does not ship MOT patch generation yet, so use a local helper for the SportsMOT ranking section. Co-authored-by: Cursor <cursoragent@cursor.com>
Prefer a local official extract when present; otherwise download the community mirror used by the original eval notebook. Co-authored-by: Cursor <cursoragent@cursor.com>
One metrics dataset is enough for the tutorial; SportsMOT remains the ranking visualization. Co-authored-by: Cursor <cursoragent@cursor.com>
Sample random crop pairs and classify same vs different player with an illustrative threshold so the notebook shows ReID beyond gallery ranking. Co-authored-by: Cursor <cursoragent@cursor.com>
Require a minimum frame gap and prefer larger gaps so pairs are not near-duplicate consecutive frames. Co-authored-by: Cursor <cursoragent@cursor.com>
Match the step-by-step subsection style used in the other ReID tutorial so each code cell has short context before it. Co-authored-by: Cursor <cursoragent@cursor.com>
Use the same Setup/Results/closing pattern, shorter imperative section prose, and GitHub package links. Co-authored-by: Cursor <cursoragent@cursor.com>
0.25 is the BoT-SORT / trackers default appearance threshold; keep paper references for the published MOT tables only. Co-authored-by: Cursor <cursoragent@cursor.com>
Point the closing link at PR roboflow#449 instead of a main-branch Colab URL that is not published yet. Co-authored-by: Cursor <cursoragent@cursor.com>
That tutorial belongs on feat/how-to-add-reid-to-trackers; keep this PR focused on the tell-objects notebook. Co-authored-by: Cursor <cursoragent@cursor.com>
Thin identity crops and filter gallery neighbors by a minimum frame gap so query-to-gallery demos are not dominated by adjacent frames. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Pull request overview
Adds a new Colab-ready tutorial notebook demonstrating object re-identification (ReID) with the reid package, and wires it into the repo’s autogenerated notebook index/table.
Changes:
- Adds a new tutorial notebook: “How to Tell Objects Apart with ReID”.
- Registers the notebook in
automation/notebooks-table-data.csvso it’s included in the autogenerated README table. - Regenerates the README notebooks table to include the new entry and updated count.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Updates the autogenerated notebooks table (count + new ReID entry). |
| automation/notebooks-table-data.csv | Adds the new notebook metadata row used by the table generator. |
| notebooks/how-to-tell-objects-apart-with-reid.ipynb | New tutorial notebook covering encoder loading, Market-1501 evaluation, and SportsMOT ranking visualization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
336
to
352
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reidpackage: load a pretrained encoder, reproduce Market-1501 gallery metrics withReIDEvaluator, and visualize query-to-gallery ranking on SportsMOT soccer cropsautomation/notebooks-table-data.csvand regenerates the README tablePR checklist
reiddocs on reid.roboflow.com (metrics guide at/latest/learn/metrics/) so the notebook doc links resolve/latest/...generate_mot_patcheshelper because PyPIreiddoes not shipreid.data.motyet. After that lands in a publishedreidrelease, switch the notebook tofrom reid.data.mot import generate_mot_patchesand drop the inline helperTest plan