This repository was archived by the owner on Oct 2, 2023. It is now read-only.
Implement custom footer - #17
Merged
Merged
Conversation
amarantha-k
approved these changes
Aug 22, 2022
amarantha-k
left a comment
amarantha-k
left a comment
Collaborator
There was a problem hiding this comment.
The preview looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had originally intended to do a very small wrapper element for the footer but since it seems like the element isn't exported from Redocly's side I had to adapt their example that reimplements it. The good news is both their footer and the old XRPL one are simple enough that I was able to get it looking and working more like the original XRPL one without all that many changes to the example code.
Some of the links in the footer are to pages that don't exist "yet" in this branch but are added in other PRs now or expected to be added at those locations soon. The links should automatically change over into working ones as those pages get added.