Skip to content

Per slot disk configuration in the helm charts #9448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
himadrisingh wants to merge 3 commits into
base: main
Choose a base branch
from
+1 −1
Open

Per slot disk configuration in the helm charts #9448

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69bbcba
Per slot disk configuration
himadrisingh May 14, 2026
a218bde
Update kubernetes.go
himadrisingh May 14, 2026
5da43f3
Apply suggestion from @himadrisingh
himadrisingh May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions admin/provisioner/kubernetes/kubernetes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,8 @@
// Create unique host
host := p.getHost(provisionID)

// Compute storage. If an override is provided on the project, it takes precedence over the slot-based default.
storageBytes := 40 * int64(args.Slots) * int64(datasize.GB)
// Compute storage. If an override is provided on the project, it takes precedence over the slot-based default.

Check failure on line 195 in admin/provisioner/kubernetes/kubernetes.go

View workflow job for this annotation

GitHub Actions / lint 

File is not properly formatted (gci)
storageBytes := int64(args.Slots) * int64(datasize.GB)
Comment thread
himadrisingh marked this conversation as resolved.
Outdated
if args.OverrideDiskGB != nil && *args.OverrideDiskGB > 0 {
storageBytes = *args.OverrideDiskGB * int64(datasize.GB)
}
Expand Down
Loading