Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/claude.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
fetch-depth: 1

- name: Run Claude PR Action
uses: anthropics/claude-code-action@beta
uses: anthropics/claude-code-action@v1
with:
anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
# Or use OAuth token instead:
Expand Down
4 changes: 3 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,14 @@ linters:
- opinionated
gosec:
excludes:
# G107: URL from variable. Rill is a connector platform that makes outbound requests to
# user-configured endpoints by design. Blanket suppression is intentional; SSRF is
# addressed at the input-validation layer, not the linter layer.
- G107
- G108
- G112
- G115
- G203
- G204
- G306
- G401
- G501
Expand Down
4 changes: 2 additions & 2 deletions cli/cmd/devtool/dotenv.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,13 +110,13 @@ func checkDotenv() error {
func downloadDotenv(ctx context.Context, preset string) error {
logInfo.Printf("Downloading .env file from %s\n", dotenvURLs[preset])

err := exec.CommandContext(ctx, "gcloud", "storage", "cp", dotenvURLs[preset], ".env").Run()
err := exec.CommandContext(ctx, "gcloud", "storage", "cp", dotenvURLs[preset], ".env").Run() //nolint:gosec // dotenvURLs values are hardcoded GCS paths, not user input
if err != nil {
return fmt.Errorf("error syncing '.env' file from GCS (you must be a Rill team member and have authenticated `gcloud`): %w", err)
}
return nil
}

func uploadDotenv(ctx context.Context, preset string) error {
return exec.CommandContext(ctx, "gcloud", "storage", "cp", ".env", dotenvURLs[preset]).Run()
return exec.CommandContext(ctx, "gcloud", "storage", "cp", ".env", dotenvURLs[preset]).Run() //nolint:gosec // dotenvURLs values are hardcoded GCS paths, not user input
}
2 changes: 1 addition & 1 deletion cli/cmd/devtool/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,7 @@ func awaitClose(ctx context.Context, chs ...<-chan struct{}) error {

// newCmd initializes an exec.Cmd that sends SIGINT instead of SIGKILL when the ctx is canceled.
func newCmd(ctx context.Context, name string, args ...string) *exec.Cmd {
cmd := exec.CommandContext(ctx, name, args...)
cmd := exec.CommandContext(ctx, name, args...) //nolint:gosec // name is always a known binary ("node", "docker", "go", "npm") hardcoded by devtool callers
cmd.Cancel = func() error {
return cmd.Process.Signal(os.Interrupt)
}
Expand Down
2 changes: 1 addition & 1 deletion runtime/drivers/clickhouse/embed.go
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ func (e *embedClickHouse) start() (*clickhouse.Options, error) {
}

func (e *embedClickHouse) startClickhouse(binPath, configPath string) (io.ReadCloser, error) {
e.cmd = exec.Command(binPath, "server", "--config-file", configPath)
e.cmd = exec.Command(binPath, "server", "--config-file", configPath) //nolint:gosec // binPath is the path of the extracted embedded ClickHouse binary, not user input
e.cmd.Stdout = io.Discard

stderr, err := e.cmd.StderrPipe()
Expand Down
4 changes: 4 additions & 0 deletions scripts/web-test-code-quality.sh
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ echo ""
echo "== NPM Install =="
npm ci

echo ""
echo "== NPM Audit =="
npm audit --audit-level=high

Comment thread
himadrisingh marked this conversation as resolved.
Outdated
if [[ "$COMMON" == "true" ]]; then
echo ""
echo "== lint and type checks for web common =="
Expand Down
Loading