Skip to content

Update SDK constraint and enhance JSString type checking #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RBT22 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update SDK constraint and enhance JSString type checking #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/util/js_interop_type_adapter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
import 'dart:js_interop';

bool isString(Object obj) {
return obj is JSString;
return obj.isA<JSString>();
}
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ repository: https://github.com/rikulo/socket_io_common
issue_tracker: https://github.com/rikulo/socket_io_common/issues

environment:
sdk: '>=3.0.0 <4.0.0'
sdk: '>=3.12.0 <4.0.0'

dependencies:
logging: '^1.2.0'
Expand Down