Changes that allow nmbl to be built in copr on all fedoras - #1
Open
marta-lewandowska wants to merge 19 commits into
Open
Changes that allow nmbl to be built in copr on all fedoras#1marta-lewandowska wants to merge 19 commits into
marta-lewandowska wants to merge 19 commits into
Conversation
marta-lewandowska
commented
May 12, 2025
marta-lewandowska
commented
Contributor
- additions to Makefile
- removal of unnecessary and unsupported modules
- conditional BuildRequires depending on distro
- name nmbl using kernel NVR
rename rpm with kernel name
conditional buildrequires changes
Contributor
Author
|
@marta-lewandowska if possible, let's rebase it and include better commit msgs. Also I see several commits that can be squashed which would remove those commits created during the dev process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.