Fix -l/--limit flag not filtering unit files#76
Merged
Conversation
`get_unit_files()` was hardcoding `*.service` as the pattern for `list_unit_files_by_patterns`, ignoring the user's `-l` filter. When `merge_unit_files()` merged these results, all disabled/static/masked services got added back to the list. Closes #75 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #75
get_unit_files()was hardcoding*.serviceas the pattern forlist_unit_files_by_patterns, completely ignoring the user's-lfilter. So whenmerge_unit_files()merged those results in, all disabled/static/masked services got added back to the list — making it look like-ldid nothing.The fix just threads
limit_unitsthrough toget_unit_files()so it uses the same patterns asget_all_services().Testing
Tested in tmux with
systemctl-tui -l apparmor.service— before the fix it showed all services, after it shows onlyapparmor.🤖 Generated with Claude Code