feat(ta): add cardinal ITN tagger, verbalizer and test cases - #2
feat(ta): add cardinal ITN tagger, verbalizer and test cases#2retheckj-star wants to merge 1 commit into
Conversation
Signed-off-by: retheckj <retheckj@nvidia.com>
mayuris-00
left a comment
mayuris-00
left a comment
There was a problem hiding this comment.
Core task is signed off - all 28 cases pass and are correct.
Resolved since last review: TODO comments removed, DCO sign-off added, commit message corrected.
There was a problem hiding this comment.
Status: Approved. Correctly left empty as a package marker, per Section 5. No action required.
There was a problem hiding this comment.
Status: Approved. Correctly left empty as a package marker, per Section 5. No action required.
There was a problem hiding this comment.
Status: Approved.
Core implementation is correct: .invert() applied to all three sources, the union is well-formed, and the tagging wrapper (integer: "…" + add_tokens) is right.
The stale TODO comments have been removed - good.
There was a problem hiding this comment.
Status: Approved.
-TODO 3 is correct: pynini.closure(NEMO_NOT_QUOTE, 1) correctly captures the digit value between the quotes, and the token-deletion logic is right.
-Stale comment removed -good. No action required.
There was a problem hiding this comment.
Status: Approved. Matches the spec's checker script and the required root location. No action required.
There was a problem hiding this comment.
Status: Approved. All 28 cases match Section 8 exactly and use the correct input~expected format.
2 participants
Language: Tamil
Task: ITN (Inverse Text Normalization)
Summary:
DCO sign-off has been added and TODO instruction comments have been removed.