-
Notifications
You must be signed in to change notification settings - Fork 26
build(deps): bump the go_modules group across 1 directory with 4 updates #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go-git v5.17.1 rejects repos with worktreeConfig extension
Medium Severity
Bumping
go-git/go-git/v5from v5.16.5 to v5.17.1 introduces strict Git extension validation (go-git/go-git#1861) that rejects repositories with unsupported extensions likeworktreeConfig. Git automatically setsextensions.worktreeConfig=truewhen usinggit worktree add, a common workflow. ThegitSHABranch()function callsgit.PlainOpenWithOptions()which will now fail with an error like "repositoryformatversion does not support extension: worktreeconfig" for these repos. This is a confirmed upstream issue (go-git/go-git#1943) with no fix planned for v5. The--autoflag forreplicated release createwill break for affected users.Reviewed by Cursor Bugbot for commit 9a751c7. Configure here.