fix(deps): fix replace directives overriding patched OTEL versions#17
Open
aa-replicated wants to merge 2 commits intomainfrom
Open
fix(deps): fix replace directives overriding patched OTEL versions#17aa-replicated wants to merge 2 commits intomainfrom
aa-replicated wants to merge 2 commits intomainfrom
Conversation
- google.golang.org/grpc: v1.71.0 → v1.80.0 (fixes critical CVE: authorization bypass via missing leading slash in :path) - go.opentelemetry.io/otel/sdk: v1.34.0 → v1.43.0 (fixes high CVEs: PATH hijacking / arbitrary code execution) - go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp: v1.32.0 → v1.43.0 (fixes medium CVE: unbounded HTTP response body reads) - go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp: v0.8.0 → v0.19.0 (fixes medium CVE: unbounded HTTP response body reads) - go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp: v1.32.0 → v1.43.0 (fixes medium CVE: unbounded HTTP response body reads) Also removes stale replace directives that were pinning otel log packages to v0.8.0, and updates all related otel packages to consistent v1.43.0 / v0.19.0 versions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The replace directives in replicated/go.mod and onepassword/go.mod were pinning otlploggrpc, otlploghttp, otel/log, and otel/sdk/log to old vulnerable versions (v0.16.0 / pre-release), overriding the patched v0.19.0 entries in the require blocks. Go replace directives take precedence over require, so the vulnerable versions were being used despite the require block listing the correct patched versions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
|
Dagger is prescriptive about its dependencies. We have to wait for this to be patched in the dagger project. |
emosbaugh
requested changes
Apr 15, 2026
Member
emosbaugh
left a comment
There was a problem hiding this comment.
The correct way to upgrade dagger dependencies from my understanding is to upgrade dagger (i use brew) and then to run dagger develop since as soon as you run dagger develop any manual updates to the go.mod are reverted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update to the recent dependabot PR fixes. Cursorbot reported that some vulnerabilities may not have been fixed. this follow up aims to patch them.
replacedirectives inreplicated/go.modandonepassword/go.modthat were overriding the patched v0.19.0 OTEL log package versions with vulnerable older versionsreplacedirectives winning overrequiredeclarationsotlploggrpc,otlploghttp,otel/log, andotel/sdk/logreplace pins fromv0.16.0/pre-release tov0.19.0(patched for CVE-2026-39882)Root Cause
Go
replacedirectives take unconditional precedence overrequireentries. Bothgo.modfiles declaredv0.19.0inrequire, but hadreplaceblocks pointing to older vulnerable versions — meaningv0.16.0was actually used at build time.Test plan
go mod tidycompletes cleanly in bothreplicated/andonepassword/go list -m all🤖 Generated with Claude Code