Allow setting an env-var during builds for a custom test branch

.buildkite/pipeline.yml

@@ -1,60 +1,9 @@
 env:
   FORCE_COLOR: 1
   GIT_TERMINAL_PROMPT: 0
+  CUSTOM_TEST_BRANCH: "master"
 
 steps:
-  - label: "Build chromium - Linux"
-    key: "build-chromium-linux-x86_64"
-    timeout_in_minutes: 60
-    plugins:
-      - thedyrt/skip-checkout#v0.1.1:
-          cd: /home/ubuntu/chromium/src
-    command: "git fetch --all && git reset --hard origin/$BUILDKITE_BRANCH && node replay_build_scripts/update-all-repos.mjs && docker build -t chromium-build-new - < Dockerfile.build && git status && node buildLinux.mjs && node replay_build_scripts/upload_build_artifacts.mjs"
-    env:
-      GOMA_SERVER_HOST: simpsonite.goma.engflow.com
-      GOMACTL_USE_PROXY: false
-      RECORD_REPLAY_BACKEND_DIR: /home/ubuntu/chromium/backend
-    agents:
-      - "runtimeType=chromiumbuild"
-      - "os=linux"
-      - "queue=runtime"
-    artifact_paths:
-      - "build_id/linux/x86_64/**"
-  - label: "Build chromium - Mac (x86)"
-    key: "build-chromium-mac-x86_64"
-    timeout_in_minutes: 60
-    plugins:
-      - thedyrt/skip-checkout#v0.1.1:
-          cd: /Users/administrator/chromium/src
-    command: "git fetch --all && git reset --hard origin/$BUILDKITE_BRANCH && node replay_build_scripts/update-all-repos.mjs && node buildMac.mjs &&  node replay_build_scripts/upload_build_artifacts.mjs"
-    env:
-      GOMA_SERVER_HOST: simpsonite.goma.engflow.com
-      GOMACTL_USE_PROXY: false
-      RECORD_REPLAY_BACKEND_DIR: /Users/administrator/chromium/backend
-    agents:
-      - "runtimeType=chromiumbuild"
-      - "os=macos"
-      - "queue=runtime"
-    artifact_paths:
-      - "build_id/macOS/x86_64/**"
-  - label: "Build chromium - Mac (arm64)"
-    key: "build-chromium-mac-arm64"
-    timeout_in_minutes: 60
-    plugins:
-      - thedyrt/skip-checkout#v0.1.1:
-          cd: /Users/administrator/chromium/src
-    command: "git fetch --all && git reset --hard origin/$BUILDKITE_BRANCH && node replay_build_scripts/update-all-repos.mjs && node buildMac.mjs &&  node replay_build_scripts/upload_build_artifacts.mjs"
-    env:
-      GOMA_SERVER_HOST: simpsonite.goma.engflow.com
-      GOMACTL_USE_PROXY: false
-      REPLAY_BUILD_ARM: true
-      RECORD_REPLAY_BACKEND_DIR: /Users/administrator/chromium/backend
-    agents:
-      - "runtimeType=chromiumbuild"
-      - "os=macos"
-      - "queue=runtime"
-    artifact_paths:
-      - "build_id/macOS/arm64/**"
   - label: "Build chromium - Windows"
     key: "build-chromium-windows"
     timeout_in_minutes: 60
@@ -72,23 +21,8 @@ steps:
     artifact_paths:
       - "build_id/windows/x86_64/**"
   - trigger: "testing-runtime-e2e"
+    build:
+      branch: "cklochek/win_crash_debug"
     label: ":hammer: Trigger Runtime Tests"
     depends_on:
-      - "build-chromium-linux-x86_64"
-      - "build-chromium-mac-x86_64"
-      - "build-chromium-mac-arm64"
       - "build-chromium-windows"
-  - label: "Metabase Test Suite"
-    depends_on: "build-chromium-linux-x86_64"
-    if: build.branch == "master"
-    agents:
-      - "runtimeType=chromiumbuild"
-      - "os=linux"
-      - "queue=runtime"
-    plugins:
-      - thedyrt/skip-checkout#v0.1.1: ~
-      - seek-oss/aws-sm#v2.3.1:
-          region: us-east-2
-          env:
-            GITHUB_AUTH_SECRET: "prod/metabase-github-secret"
-    command: "/home/ubuntu/chromium/src/replay_build_scripts/metabase.sh"

DEPS

@@ -1137,7 +1137,7 @@ deps = {
     Var('chromium_git') + '/external/github.com/chromium/content_analysis_sdk.git' + '@' + '3d3f3d6f27288d7b0628ae5259238162c5e5ae76',
 
   'src/third_party/dav1d/libdav1d':
-    Var('chromium_git') + '/external/github.com/videolan/dav1d.git' + '@' + '87f9a81cd770e49394a45deca7a3df41243de00b',
+    'https://github.com/replayio/dav1d.git' + '@' + 'f2f4be6f260572026851eb42030d131b4b5bb1d1',
 
   'src/third_party/dawn':
     Var('dawn_git') + '/dawn.git' + '@' +  Var('dawn_revision'),

base/task/thread_pool/thread_pool_impl.cc

@@ -153,12 +153,16 @@ void ThreadPoolImpl::Start(const ThreadPoolInstance::InitParams& init_params,
       MessagePumpType::DEFAULT;
 #endif
   service_thread_options.timer_slack = TIMER_SLACK_MAXIMUM;
+  recordreplay::Assert("Start 1");
   CHECK(service_thread_.StartWithOptions(std::move(service_thread_options)));
+  recordreplay::Assert("Start 2");
   if (g_synchronous_thread_start_for_testing)
     service_thread_.WaitUntilThreadStarted();
+  recordreplay::Assert("Start 3");
 
 #if HAS_NATIVE_THREAD_POOL()
   if (FeatureList::IsEnabled(kUseNativeThreadPool)) {
+    recordreplay::Assert("Start 4");
     std::unique_ptr<ThreadGroup> old_group =
         std::move(foreground_thread_group_);
     foreground_thread_group_ = std::make_unique<ThreadGroupNativeImpl>(
@@ -170,8 +174,11 @@ void ThreadPoolImpl::Start(const ThreadPoolInstance::InitParams& init_params,
     old_group->InvalidateAndHandoffAllTaskSourcesToOtherThreadGroup(
         foreground_thread_group_.get());
   }
+  recordreplay::Assert("Start 5");
 
   if (FeatureList::IsEnabled(kUseBackgroundNativeThreadPool)) {
+    recordreplay::Assert("Start 6");
+
     std::unique_ptr<ThreadGroup> old_group =
         std::move(background_thread_group_);
     background_thread_group_ = std::make_unique<ThreadGroupNativeImpl>(
@@ -575,6 +582,7 @@ ThreadGroup* ThreadPoolImpl::GetThreadGroupForTraits(const TaskTraits& traits) {
 }
 
 void ThreadPoolImpl::UpdateCanRunPolicy() {
+  recordreplay::Assert("UpdateCanRunPolicy");
   DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
 
   CanRunPolicy can_run_policy;
@@ -591,10 +599,14 @@ void ThreadPoolImpl::UpdateCanRunPolicy() {
 
   task_tracker_->SetCanRunPolicy(can_run_policy);
   foreground_thread_group_->DidUpdateCanRunPolicy();
-  if (background_thread_group_)
+  if (background_thread_group_) {
+    recordreplay::Assert("UpdateCanRunPolicy 1");
     background_thread_group_->DidUpdateCanRunPolicy();
-  if (record_replay_unordered_thread_group_)
+  }
+  if (record_replay_unordered_thread_group_) {
+    recordreplay::Assert("UpdateCanRunPolicy 2");
     record_replay_unordered_thread_group_->DidUpdateCanRunPolicy();
+  }
   single_thread_task_runner_manager_.DidUpdateCanRunPolicy();
 }
 

base/threading/platform_thread_win.cc

@@ -181,6 +181,7 @@ bool CreateThreadInternal(size_t stack_size,
                           PlatformThreadHandle* out_thread_handle,
                           ThreadType thread_type,
                           MessagePumpType message_pump_type) {
+  recordreplay::Assert("CreateThreadInternal");
   // Make sure we instantiate this now so we don't race to create it later.
   GetRecordReplayThreadJoinOrderedLockId();
 

base/threading/thread.cc

@@ -168,6 +168,7 @@ bool Thread::Start() {
 }
 
 bool Thread::StartWithOptions(Options options) {
+  recordreplay::Assert("StartWithOptions");
   DCHECK(options.IsValid());
   DCHECK(owning_sequence_checker_.CalledOnValidSequence());
   DCHECK(!delegate_);
@@ -207,6 +208,9 @@ bool Thread::StartWithOptions(Options options) {
   // fixed).
   {
     AutoLock lock(thread_lock_);
+
+    recordreplay::Assert("Start with options %d", (int)options.joinable);
+
     bool success = options.joinable
                        ? PlatformThread::CreateWithType(
                              options.stack_size, this, &thread_,

replay_build_scripts/common.mjs

@@ -139,7 +139,9 @@ export function updateChromiumRepo() {
   syncRepo(path.join(chromium, "third_party", "skia"), deps.skia);
 
   syncRepo(path.join(chromium, "third_party", "webrtc"), deps.webrtc);
-
+
+  syncRepo(path.join(chromium, "third_party", "dav1d", "libdav1d"), deps.dav1d);
+
   syncRepo(
     path.join(chromium, "third_party", "boringssl", "src"),
     deps.boringssl
@@ -172,6 +174,13 @@ function getChromiumDeps() {
   assert(match, "Could not find webrtc revision");
   results.webrtc = match[1];
 
+  match =
+  /'https:\/\/github.com\/replayio\/dav1d.git' \+ '@' \+ '(.*?)'/.exec(
+    text
+  );
+  assert(match, "Could not find dav1d revision");
+  results.dav1d = match[1];
+
   match = /'boringssl_revision': '(.*?)'/.exec(text);
   assert(match, "Could not find boringssl revision");
   results.boringssl = match[1];