Skip to content

Remove some old asserts that I was working on before the pivot #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Domiii merged 1 commit into from
Dec 13, 2024
Merged

Remove some old asserts that I was working on before the pivot #1313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion components/page_load_metrics/renderer/metrics_render_frame_observer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ class MojoPageTimingSender : public PageTimingSender {
const absl::optional<blink::MobileFriendliness>& mobile_friendliness,
uint32_t soft_navigation_count) override {
DCHECK(page_load_metrics_);
mojo::internal::AutoRecordReplayAssertBufferAllocations assertsEnabled("TT-366-1124");
page_load_metrics_->UpdateTiming(
limited_sending_mode_ ? CreatePageLoadTiming() : timing->Clone(),
metadata->Clone(), new_features, std::move(resources),
Expand Down
6 changes: 0 additions & 6 deletions components/page_load_metrics/renderer/page_timing_metrics_sender.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,12 +329,6 @@ void PageTimingMetricsSender::SendNow() {
}
}

REPLAY_ASSERT(
"[TT-366-1366] PageTimingMetricsSender::SendNow %zu %zu %zu %zu",
new_features_.size(), resources.size(),
(size_t)modified_resources_.size(),
(size_t)page_resource_data_use_.size());

sender_->SendTiming(last_timing_, metadata_, std::move(new_features_),
std::move(resources), render_data_, last_cpu_timing_,
std::move(input_timing_delta_), mobile_friendliness_,
Expand Down
4 changes: 0 additions & 4 deletions third_party/blink/common/use_counter/use_counter_feature_tracker.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@ bool UseCounterFeatureTracker::Test(const UseCounterFeature& feature) const {

bool UseCounterFeatureTracker::TestAndSet(const UseCounterFeature& feature) {
bool has_record = Test(feature);
REPLAY_ASSERT("[TT-366-1456] UseCounterFeatureTracker::TestAndSet %d %d %u",
has_record,
feature.type(),
feature.value());
Set(feature, true);
return has_record;
}
Expand Down
7 changes: 0 additions & 7 deletions third_party/blink/renderer/core/css/parser/css_parser_context.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,9 +229,6 @@ KURL CSSParserContext::CompleteURL(const String& url) const {
}

void CSSParserContext::Count(WebFeature feature) const {
REPLAY_ASSERT("[TT-366-1467] CSSParserContext::Count feat %d %d",
IsUseCounterRecordingEnabled(),
feature);
if (IsUseCounterRecordingEnabled())
document_->CountUse(feature);
}
Expand All @@ -242,10 +239,6 @@ void CSSParserContext::CountDeprecation(WebFeature feature) const {
}

void CSSParserContext::Count(CSSParserMode mode, CSSPropertyID property) const {
REPLAY_ASSERT("[TT-366-1467] CSSParserContext::Count prop %d %d %d",
IsUseCounterRecordingEnabled(),
(int)mode,
property);
if (IsUseCounterRecordingEnabled() && IsUseCounterEnabledForMode(mode)) {
document_->CountProperty(property);
}
Expand Down
6 changes: 0 additions & 6 deletions third_party/blink/renderer/core/dom/document.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8749,9 +8749,6 @@ void Document::CountUse(mojom::WebFeature feature) const {
}

void Document::CountUse(mojom::WebFeature feature) {
REPLAY_ASSERT("[TT-366-1467] Document::CountUse %d %d",
!!execution_context_,
feature);
if (execution_context_)
execution_context_->CountUse(feature);
}
Expand All @@ -8762,9 +8759,6 @@ void Document::CountDeprecation(mojom::WebFeature feature) {
}

void Document::CountProperty(CSSPropertyID property) const {
REPLAY_ASSERT("[TT-366-1467] Document::CountProperty %d %d",
!!Loader(),
property);
if (DocumentLoader* loader = Loader()) {
loader->GetUseCounter().Count(
property, UseCounterImpl::CSSPropertyType::kDefault, GetFrame());
Expand Down
3 changes: 0 additions & 3 deletions third_party/blink/renderer/core/frame/local_dom_window.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,9 +725,6 @@ void LocalDOMWindow::AddInspectorIssue(AuditsIssue issue) {
}

void LocalDOMWindow::CountUse(mojom::WebFeature feature) {
REPLAY_ASSERT("[TT-366-1467] LocalDOMWindow::CountUse %d %d",
!!GetFrame(),
GetFrame() ? !!GetFrame()->Loader().GetDocumentLoader() : -1);
if (!GetFrame())
return;
if (auto* loader = GetFrame()->Loader().GetDocumentLoader())
Expand Down
6 changes: 0 additions & 6 deletions third_party/blink/renderer/core/frame/use_counter_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,12 +179,6 @@ void UseCounterImpl::Count(const UseCounterFeature& feature,
if (recordreplay::AreEventsDisallowed("UseCounterImpl::Count"))
return;

REPLAY_ASSERT("[TT-366-1467] UseCounterImpl::Count %d %u %d %d",
!!source_frame,
mute_count_,
feature.type(),
feature.value());

if (!source_frame)
return;

Expand Down