Skip to content

Assert SequenceManagerImpl::AdjustWakeUp #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Domiii wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Assert SequenceManagerImpl::AdjustWakeUp #1300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions base/task/sequence_manager/sequence_manager_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,10 +563,6 @@ void SequenceManagerImpl::SetNextWakeUp(LazyNow* lazy_now,
absl::optional<WakeUp> wake_up) {
auto next_wake_up = AdjustWakeUp(wake_up, lazy_now);

recordreplay::Assert(
"[RUN-2801-2978] SequenceManagerImpl::SetNextWakeUp %d",
next_wake_up && next_wake_up->is_immediate());

if (next_wake_up && next_wake_up->is_immediate()) {
ScheduleWork();
} else {
Expand Down Expand Up @@ -828,6 +824,13 @@ absl::optional<WakeUp> SequenceManagerImpl::AdjustWakeUp(
absl::optional<WakeUp> wake_up,
LazyNow* lazy_now) const {
DCHECK_CALLED_ON_VALID_THREAD(associated_thread_->thread_checker);

REPLAY_ASSERT_MAYBE_EVENTS_DISALLOWED(
"[TT-1504-1505] SequenceManagerImpl::AdjustWakeUp A %d %d %llu",
!!wake_up,
wake_up && wake_up->is_immediate(),
wake_up->earliest_time().ToInternalValue());

if (!wake_up)
return absl::nullopt;

Expand All @@ -838,6 +841,10 @@ absl::optional<WakeUp> SequenceManagerImpl::AdjustWakeUp(
// up scheduled, so pretend we have no more work. This will result in
// appearing idle and |time_domain| will decide what to do in
// MaybeFastForwardToWakeUp().
REPLAY_ASSERT_MAYBE_EVENTS_DISALLOWED(
"[TT-1504-1505] SequenceManagerImpl::AdjustWakeUp B %d",
!!main_thread_only().time_domain);

if (main_thread_only().time_domain)
return absl::nullopt;
return *wake_up;
Expand Down