Open
Conversation
Domiii
commented
May 10, 2024
Domiii
commented
- paired w/ [TT-1112] Fix the sourcemap handler script chromium-v8#242
- https://linear.app/replay/issue/TT-1112/fix-the-sourcemap-handler-script-in-chromium#comment-958e0140
…-1112-root-cause-the-fetch-when-context-is-gone-recorder-crash
…-1112-root-cause-the-fetch-when-context-is-gone-recorder-crash
Domiii
commented
May 10, 2024
| return res; | ||
| } | ||
|
|
||
| addNewScriptHandler("sourcemaps", async (scriptId, sourceURL, relativeSourceMapURL) => { |
Domiii
commented
May 10, 2024
| } | ||
|
|
||
| addNewScriptHandler((scriptId, sourceURL, relativeSourceMapURL) => { | ||
| addNewScriptHandler("commands", (scriptId, sourceURL, relativeSourceMapURL) => { |
Domiii
commented
May 10, 2024
Domiii
commented
May 10, 2024
|
|
||
| namespace blink { | ||
|
|
||
| extern bool LocalDOMWindowPointerIsValid(LocalDOMWindow* window); |
toshok
approved these changes
May 10, 2024
Comment on lines
+141
to
+145
| const AssetFiles = [ | ||
| "replay_command_handlers.js", | ||
| "replay_sourcemap_handler.js", | ||
| ]; | ||
|
|
There was a problem hiding this comment.
is this (coupled with the block 156-158 below) the only change to this file?
| const rv = spawnSync(cmd, args, options); | ||
|
|
||
| if (rv.status != 0 || rv.error) { | ||
| if (rv.status || rv.error || rv.signal) { |
There was a problem hiding this comment.
is this related to this change or TT-1150?
Author
There was a problem hiding this comment.
The latter. But also: Its just a bug in this function 🤷♀️
Author
|
Tried it a few more times locally: It seems to work! |
Author
|
Update:
|
…-1112-root-cause-the-fetch-when-context-is-gone-recorder-crash
…-1112-root-cause-the-fetch-when-context-is-gone-recorder-crash
…-1112-root-cause-the-fetch-when-context-is-gone-recorder-crash
…-1112-root-cause-the-fetch-when-context-is-gone-recorder-crash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.