Repository navigation
fix(remark-stringify): omit trailing breaks that cannot round-trip - #1497
Closed
BetterAndBetterII wants to merge 1 commit into
Closed
BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
CommonMark cannot parse a trailing `\`+newline as a hard break, so emitting one turned a trailing break into a literal backslash on parse. Drop trailing breaks on stringify; keep mid-phrasing breaks unchanged. Fixes remarkjs#1477
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1497 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 138 173 +35
=========================================
+ Hits 138 173 +35 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Thanks @BetterAndBetterII! |
Member
|
this is not the place to do that |
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
added
👎 phase/no
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop trailing break nodes on stringify so they do not round-trip as a literal backslash under CommonMark. Mid-phrasing breaks are unchanged. Fixes #1477