Add support for artifactDirectory option#38
Merged
danielholmes merged 1 commit intorelay-tools:masterfrom Dec 20, 2018
Merged
Conversation
Collaborator
|
@jnak this is great, thanks very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This adds support for the artifactDirectory option in Relay that was added in the Language plugin support PR. This option allows to compile all artifact in a single directory, which is necessary to get generated Flow types work.
Thanks for writing good tests. Without them, I would probably have not contributed this change back.
Cheers,
J