Skip to content

Deep match actions - #5

Open
tarling wants to merge 3 commits into
redux-things:masterfrom
tarling:deep-match-actions
Open

Deep match actions#5
tarling wants to merge 3 commits into
redux-things:masterfrom
tarling:deep-match-actions

Conversation

@tarling

@tarling tarling commented Oct 12, 2017

Copy link
Copy Markdown

Lodash's findIndex is currently used in src/asserts/utils/assertDispatchedActions.js and src/asserts/utils/assertNotDispatchedActions.js for comparing actions against expected actions. This will give a false positive in some cases. e.g. it will match:

{ type: '0', payload: [{ a: '0' }, { b: '1' }, { c: '2' }] }

against

{ type: '0', payload: [] }

Suggest isEqual is used as a predicate in findIndex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant