Skip to content

Repair the Spring Data Redis Integration Test#3810

Merged
tishun merged 2 commits into
redis:mainfrom
tishun:topic/tishu/sdr-precheck-failing
Jun 29, 2026
Merged

Repair the Spring Data Redis Integration Test#3810
tishun merged 2 commits into
redis:mainfrom
tishun:topic/tishu/sdr-precheck-failing

Conversation

@tishun

@tishun tishun commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

The problem

This is a direct consequence of spring-projects/spring-data-build#2886

That commit added a maven-dependency-plugin execution unpack-javadoc-offline-links that unpacks the javadoc classifier jar of io.lettuce:lettuce-core (and redis.clients:jedis) to wire up Javadoc offline links:

On the side of Lettuce automation the workflow's "Build Lettuce" step only installed the main + sources jars, so the build failed in an early phase — before any test ran, which is why the artifact-upload step also reported empty surefire-reports.

The fix

The "Build Lettuce" step now runs

mvn -B clean javadoc:jar install -DskipTests -Dgpg.skip=true -Dmaven.javadoc.failOnError=false

so the javadoc jar is attached and installed into the local ~/.m2 for SDR to consume.

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

Note

Low Risk
CI-only Maven command change with no runtime or library behavior impact.

Overview
Fixes the Spring Data Redis integration workflow failing before tests run because upstream SDR now unpacks the io.lettuce:lettuce-core javadoc classifier for offline Javadoc links, while CI only installed the main (and sources) artifacts.

The Build Lettuce step now runs javadoc:jar as part of mvn clean install, with -Dmaven.javadoc.failOnError=false, so the javadoc jar is attached and published to the local ~/.m2 for the patched SDR build to consume.

Reviewed by Cursor Bugbot for commit 8a43d82. Bugbot is set up for automated code reviews on this repo. Configure here.

@tishun tishun requested a review from a-TODO-rov June 29, 2026 08:15
@tishun tishun merged commit c98ace2 into redis:main Jun 29, 2026
13 of 14 checks passed
@tishun tishun deleted the topic/tishu/sdr-precheck-failing branch June 29, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant