Repair the Spring Data Redis Integration Test#3810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
This is a direct consequence of spring-projects/spring-data-build#2886
That commit added a maven-dependency-plugin execution unpack-javadoc-offline-links that unpacks the javadoc classifier jar of io.lettuce:lettuce-core (and redis.clients:jedis) to wire up Javadoc offline links:
On the side of Lettuce automation the workflow's "Build Lettuce" step only installed the main + sources jars, so the build failed in an early phase — before any test ran, which is why the artifact-upload step also reported empty surefire-reports.
The fix
The "Build Lettuce" step now runs
so the javadoc jar is attached and installed into the local ~/.m2 for SDR to consume.
Make sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.Note
Low Risk
CI-only Maven command change with no runtime or library behavior impact.
Overview
Fixes the Spring Data Redis integration workflow failing before tests run because upstream SDR now unpacks the
io.lettuce:lettuce-corejavadoc classifier for offline Javadoc links, while CI only installed the main (and sources) artifacts.The Build Lettuce step now runs
javadoc:jaras part ofmvn clean install, with-Dmaven.javadoc.failOnError=false, so the javadoc jar is attached and published to the local~/.m2for the patched SDR build to consume.Reviewed by Cursor Bugbot for commit 8a43d82. Bugbot is set up for automated code reviews on this repo. Configure here.