Memoize reopened pools while holding the mutex - #313
Merged
byroot merged 1 commit intoAug 27, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@poolinside the reopening mutex.closeon a single pool, preserving its configured capacity.Reproduction
Create
RedisClient.config.new_pool(size: 1), close it, hold its@mutex, and start two threads invoking its privatepoolaccessor. Wait until both threads block on that mutex, then release it and join both with deadlines. Shut down both returned pools during cleanup.Before: the two callers receive different ConnectionPool objects.
After: both receive the same object.
The outer
||=evaluates the nil value before either caller acquires the mutex. Serializing only construction still creates a second pool and overwrites the first one. Memoizing inside the lock avoids that race without adding locking to the normal non-nil path.Verification
Compatibility and limitations
No intended breaking changes, API or dependency changes. Reopening after close remains supported. This does not redefine concurrent shutdown/check-out semantics. Other Ruby implementations and upstream CI are not yet locally verified. No test files added or modified, per the originating project's policy; the focused reproduction was run outside the repository.
Prepared with Codex assistance; findings and checks above were reproduced locally.