Recheck circuit state inside the recovery lock - #312
Merged
byroot merged 1 commit intoAug 27, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reproduction
On 0.30.1/master, create a breaker with
error_threshold: 1, error_timeout: 0and trigger oneRedisClient::ConnectionError. Hold its@lock, start two threads callingbreaker.protect { :success }, wait until both threads block on that mutex, then release it and join both with a deadline.Before: one succeeds; the other raises
NoMethodErroron@errors.last < ....After: both return
:success.Both callers observe the open state before waiting. The first clears the errors when closing; the second must check state again under the lock. This is separate from the already-merged error-window correction in #247.
Verification
Style/EmptyClassDefinitionoffense onOpenCircuitError. No lint configuration changed.Compatibility and limitations
No intended breaking changes, API changes, dependency changes or altered threshold policy. Other Ruby implementations and upstream CI are not yet locally verified. No test files added or modified, per the originating project's policy; the focused reproduction was run outside the repository.
Prepared with Codex assistance; findings and checks above were reproduced locally.