Additional tests

e2e/testdata/scenarios/01_warehouse_decrease/expected_comment.txt

@@ -0,0 +1,12 @@
+<!-- naysayer-comment-id: approval -->
+✅ **Auto-approved**
+
+<details>
+<summary>📋 <strong>Analysis Details</strong> (click to expand)</summary>
+
+**What was checked:**
+• ✅ Metadata validated: Product metadata changes (name, tags, kind) are safe and don't affect infrastructure
+• ✅ TOC approval check: Changes to existing products in non-critical environments
+• ✅ Warehouse configuration validated: Warehouse size decrease saves costs and is safe to auto-approve
+
+</details>

e2e/testdata/scenarios/02_warehouse_increase/expected_comment.txt

@@ -0,0 +1,15 @@
+<!-- naysayer-comment-id: manual-review -->
+⚠️ **Manual review required**
+
+**Why manual review is needed:**
+One or more files require manual review
+
+<details>
+<summary>📋 <strong>Analysis Details</strong> (click to expand)</summary>
+
+**What was checked:**
+• ✅ Metadata validated: Product metadata changes (name, tags, kind) are safe and don't affect infrastructure
+• ✅ TOC approval check: Changes to existing products in non-critical environments
+• 🚫 Warehouse configuration validated: Warehouse size increase detected: user warehouse: SMALL → MEDIUM
+
+</details>

e2e/testdata/scenarios/02_toc_approval/toc_new_prod/after/dataproducts/sales/prod/product.yaml → e2e/testdata/scenarios/03_toc_new_prod/after/dataproducts/sales/prod/product.yaml

@@ -1,7 +1,7 @@
 ---
 name: sales-analytics
 kind: source-aligned
-rover_group: dataverse-source-sales
+rover_group: example-sales
 warehouses:
 - type: user
   size: LARGE
@@ -11,8 +11,8 @@ service_account:
   dbt: true
 tags:
   data_product: sales
+  tier: production
 data_product_db:
-- database: sales_db
   presentation_schemas:
-  - name: marts
+  - name: reporting
     consumers: []

e2e/testdata/scenarios/03_toc_new_prod/expected_comment.txt

@@ -0,0 +1,15 @@
+<!-- naysayer-comment-id: manual-review -->
+⚠️ **Manual review required**
+
+**Why manual review is needed:**
+One or more files require manual review
+
+<details>
+<summary>📋 <strong>Analysis Details</strong> (click to expand)</summary>
+
+**What was checked:**
+• ✅ Metadata validated: Product metadata changes (name, tags, kind) are safe and don't affect infrastructure
+• 🚫 TOC approval check: Manual review required: New data product being promoted to prod environment requires TOC (Technical Oversight Committee) approval before deployment
+• 🚫 Warehouse configuration validated: Warehouse size increase detected: New user warehouse: LARGE, New service_account warehouse: XSMALL
+
+</details>

e2e/testdata/scenarios/03_toc_new_prod/scenario.yaml

@@ -0,0 +1,17 @@
+name: "New product.yaml in prod"
+description: "New product.yaml in prod environment requires TOC approval"
+
+expected:
+  decision: ManualReview
+  reason: "One or more files require manual review"
+  approved: false
+
+  comment_contains:
+    - "⚠️ **Manual review required**"
+    - "TOC approval"
+
+mr_metadata:
+  title: "Deploy new sales-analytics product to production"
+  author: "testuser"
+  source_branch: "feature/new-sales-product"
+  target_branch: "main"

e2e/testdata/scenarios/01_single_rule_single_file/consumer_only_prod/before/dataproducts/analytics/prod/product.yaml → e2e/testdata/scenarios/04_consumer_only_prod/after/dataproducts/analytics/prod/product.yaml

@@ -1,7 +1,7 @@
 ---
 name: analytics
 kind: source-aligned
-rover_group: dataverse-source-analytics
+rover_group: example-analytics
 warehouses:
 - type: user
   size: MEDIUM
@@ -12,7 +12,10 @@ service_account:
 tags:
   data_product: analytics
 data_product_db:
-- database: analytics_db
   presentation_schemas:
   - name: marts
+    consumers:
+    - name: journey
+      kind: data_product
+  - name: staging
     consumers: []

e2e/testdata/scenarios/04_integration/integration_uncovered_lines/before/dataproducts/analytics/prod/product.yaml → e2e/testdata/scenarios/04_consumer_only_prod/before/dataproducts/analytics/prod/product.yaml

@@ -1,7 +1,7 @@
 ---
 name: analytics
 kind: source-aligned
-rover_group: dataverse-source-analytics
+rover_group: example-analytics
 warehouses:
 - type: user
   size: MEDIUM
@@ -12,7 +12,8 @@ service_account:
 tags:
   data_product: analytics
 data_product_db:
-- database: analytics_db
   presentation_schemas:
   - name: marts
     consumers: []
+  - name: staging
+    consumers: []

e2e/testdata/scenarios/04_consumer_only_prod/expected_comment.txt

@@ -0,0 +1,10 @@
+<!-- naysayer-comment-id: approval -->
+✅ **Auto-approved**
+
+<details>
+<summary>📋 <strong>Analysis Details</strong> (click to expand)</summary>
+
+**What was checked:**
+• ✅ TOC approval check: Changes to existing products in non-critical environments
+
+</details>

e2e/testdata/scenarios/01_single_rule_single_file/consumer_only_prod/scenario.yaml → e2e/testdata/scenarios/04_consumer_only_prod/scenario.yaml

@@ -1,19 +1,13 @@
 name: "Consumer-only changes in prod"
-description: "Adding consumers to product.yaml should auto-approve (owner approval sufficient, no TOC needed)"
+description: "Consumer-only changes should be auto-approved (owner approval sufficient)"
 
 expected:
   decision: Approve
   reason: "All files passed validation - all changes covered by approved rules"
   approved: true
 
-  rules_evaluated:
-    - name: dataproduct_consumer_rule
-      section: consumers
-      decision: Approve
-
   comment_contains:
     - "✅ **Auto-approved**"
-    - "TOC approval check"
 
 mr_metadata:
   title: "Grant journey product access to analytics data"

e2e/testdata/scenarios/05_metadata_readme/after/dataproducts/analytics/README.md

@@ -0,0 +1,18 @@
+# Analytics Product
+
+## Overview
+
+This is the analytics data product for our organization.
+
+## Setup Instructions
+
+New and improved setup instructions with detailed steps:
+
+1. Clone the repository
+2. Configure your environment
+3. Run the initialization script
+4. Verify the setup
+
+## Contact
+
+Data Team - analytics@example.com

e2e/testdata/scenarios/05_metadata_readme/before/dataproducts/analytics/README.md

@@ -0,0 +1,13 @@
+# Analytics Product
+
+## Overview
+
+This is the analytics data product for our organization.
+
+## Setup Instructions
+
+Old setup instructions go here.
+
+## Contact
+
+Data Team

e2e/testdata/scenarios/05_metadata_readme/expected_comment.txt

@@ -0,0 +1,10 @@
+<!-- naysayer-comment-id: approval -->
+✅ **Auto-approved**
+
+<details>
+<summary>📋 <strong>Analysis Details</strong> (click to expand)</summary>
+
+**What was checked:**
+• ✅ Metadata validated: Product metadata changes (name, tags, kind) are safe and don't affect infrastructure
+
+</details>

e2e/testdata/scenarios/05_metadata_readme/scenario.yaml

@@ -0,0 +1,16 @@
+name: "README.md update"
+description: "README updates should be auto-approved (documentation only)"
+
+expected:
+  decision: Approve
+  reason: "All files passed validation - all changes covered by approved rules"
+  approved: true
+
+  comment_contains:
+    - "✅ **Auto-approved**"
+
+mr_metadata:
+  title: "Update README with new setup instructions"
+  author: "testuser"
+  source_branch: "feature/update-docs"
+  target_branch: "main"

e2e/testdata/scenarios/06_metadata_product_sections/after/dataproducts/analytics/prod/product.yaml

@@ -0,0 +1,7 @@
+---
+name: analytics-v2
+kind: source-aligned
+rover_group: example-analytics
+tags:
+  data_product: analytics
+  pii: true