tracing: log v2-enabled message at info level#715
Merged
Conversation
The "v2 tracing is enabled; skipping v0 tracer configuration" message was emitted through cfg.Logger, a log.Wrapper. Wrapper is documented for unexpected/recoverable errors and defaults to ErrorWithSentryWrapper, so this informational message was being logged at ERROR level and captured by Sentry. Switch to log.Info so it respects the global logger's level (suppressed when configured at ERROR) and never reaches Sentry.
jon-whit
requested review from
konradreiche,
mathyourlife-reddit,
pacejackson and
will-meng
and removed request for
a team
pacejackson
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "v2 tracing is enabled; skipping v0 tracer configuration" message was emitted through cfg.Logger - if a client sets their configured log level to ERROR then this logs at error level. This is purely informational - it shouldn't be logged at the log level set on the logger. It should always be logged as an info level log. It is also logged before the logger is constructed - so it ought to use the default global logger at this point in the constructor.
This fixes the log level so that clients using this API surface don't get spammy error logs.
✅ Checks