Conversation
📝 WalkthroughWalkthroughAdded comprehensive AI agent skills documentation for Convex across three agent ecosystems (.agents, .claude, .windsurf), including guides for quickstart, authentication setup, component creation, schema migrations, and performance audits. Simultaneously integrated Google Gemini API for server-side blog content generation and improvement, enhanced the post editor with draft management and AI-assisted writing features, and updated dependencies to support form validation and rich-text editing. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes The diff is predominantly documentation (>80% of lines), which is repetitive across directories and straightforward to review. However, the application code introduces several new features requiring careful examination: Gemini API integration with error handling, multi-component form-driven post editor with Convex mutations, async state management for AI operations, and hook typing improvements. The heterogeneous nature (documentation + diverse code changes) and moderate logic density across multiple files warrant a full read-through, though the documentation volume doesn't significantly increase effort. Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 18
🧹 Nitpick comments (20)
README.md (1)
1-1: Optional: Consider hyphenating the compound adjective.When "Full Stack" is used as a compound adjective modifying "AI Content Platform," it should technically be hyphenated as "Full-Stack" for proper English grammar.
📝 Optional style fix
-# Full Stack AI Content Platform using Next JS, Tailwind, React Quill, ImageKit, Shadcn UI, Clerk and Convex +# Full-Stack AI Content Platform using Next JS, Tailwind, React Quill, ImageKit, Shadcn UI, Clerk and Convex🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` at line 1, The README header uses "Full Stack" as a compound adjective; update it to "Full-Stack" to read "Full-Stack AI Content Platform using Next JS, Tailwind, React Quill, ImageKit, Shadcn UI, Clerk and Convex" (search for the title string in README.md and replace the unhyphenated form; also scan for other occurrences of "Full Stack" and hyphenate them consistently)..claude/skills/convex-performance-audit/agents/openai.yaml (1)
1-10: Consider a single source-of-truth for duplicated agent YAMLs.Line 1-Line 10 matches equivalent files in other agent ecosystems. Keeping this in sync manually can drift over time; consider generating these files from one template/source.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.claude/skills/convex-performance-audit/agents/openai.yaml around lines 1 - 10, The agent YAML duplicates top-level interface fields (display_name, short_description, icon_small, icon_large, brand_color, default_prompt, policy.allow_implicit_invocation) across ecosystems; create a single source-of-truth template (e.g., a canonical agent template or JSON/YAML schema) and replace this file with a generated artifact: add a small generation script or makefile target that emits .claude/skills/convex-performance-audit/agents/openai.yaml from the template, update CI to run a validation/generation step (or fail if out-of-date), and refactor any build or repo docs to point to the canonical template so the keys above are kept in sync automatically..claude/skills/convex-performance-audit/references/occ-conflicts.md (1)
1-114: Consider consolidating identical OCC conflict reference files across agent ecosystems.The files
.claude/skills/convex-performance-audit/references/occ-conflicts.mdand.agents/skills/convex-performance-audit/references/occ-conflicts.mdare identical. Maintaining separate copies creates a maintenance burden—future updates must be applied twice to keep them in sync. Consider a single shared reference with symlinks or a shared documentation structure instead.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.claude/skills/convex-performance-audit/references/occ-conflicts.md around lines 1 - 114, Duplicate OCC conflict reference files exist (two identical copies), causing maintenance overhead; remove one copy and consolidate to a single canonical reference, update any consumers to point to that canonical file, and optionally replace the removed copy with a symlink or a shared docs/include mechanism so future edits are made once. Ensure the canonical file (occ-conflicts.md) remains in the shared references location used by both agent ecosystems and update any documentation/build/config that referenced the removed duplicate to use the canonical path..windsurf/skills/convex-performance-audit/references/subscription-cost.md (1)
170-172: Optional: Rephrase to avoid repetitive sentence openings.Three successive sentences begin with "Queries," which reduces readability. Consider varying the sentence structure (same issue as in the
.agents/version of this file).📝 Suggested rewording
-Queries that only need `name` and `email` no longer re-run on every heartbeat. Queries that actually need online status fetch the heartbeat document explicitly. +Queries that only need `name` and `email` no longer re-run on every heartbeat. Those that actually need online status can fetch the heartbeat document explicitly. -For an even further optimization, if you only need a coarse online/offline boolean rather than the exact `lastSeen` timestamp, add a separate presence document with an `isOnline` flag. Update it immediately when a user comes online, and use a cron to batch-mark users offline when their heartbeat goes stale. This way the presence query only invalidates when online status actually changes, not on every heartbeat. +For further optimization, if you only need a coarse online/offline boolean rather than the exact `lastSeen` timestamp, add a separate presence document with an `isOnline` flag. Update it immediately when a user comes online, and use a cron to batch-mark users offline when their heartbeat goes stale. This way the presence query only invalidates when online status actually changes, not on every heartbeat.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.windsurf/skills/convex-performance-audit/references/subscription-cost.md around lines 170 - 172, Reword the three consecutive sentences that start with "Queries" to improve readability: locate the sentences beginning "Queries that only need `name` and `email` no longer re-run on every heartbeat," "Queries that actually need online status fetch the heartbeat document explicitly," and the sentence proposing the `isOnline` presence document, then vary the sentence openings (for example, start the second sentence with "When online status is required, ..." and the third with "For an additional optimization, ...") while preserving the original meaning and the referenced terms (`name`, `email`, `heartbeat document`, `isOnline` flag)..agents/skills/convex-performance-audit/references/subscription-cost.md (1)
170-172: Optional: Rephrase to avoid repetitive sentence openings.Three successive sentences begin with "Queries," which reduces readability. Consider varying the sentence structure.
📝 Suggested rewording
-Queries that only need `name` and `email` no longer re-run on every heartbeat. Queries that actually need online status fetch the heartbeat document explicitly. +Queries that only need `name` and `email` no longer re-run on every heartbeat. Those that actually need online status can fetch the heartbeat document explicitly. -For an even further optimization, if you only need a coarse online/offline boolean rather than the exact `lastSeen` timestamp, add a separate presence document with an `isOnline` flag. Update it immediately when a user comes online, and use a cron to batch-mark users offline when their heartbeat goes stale. This way the presence query only invalidates when online status actually changes, not on every heartbeat. +For further optimization, if you only need a coarse online/offline boolean rather than the exact `lastSeen` timestamp, add a separate presence document with an `isOnline` flag. Update it immediately when a user comes online, and use a cron to batch-mark users offline when their heartbeat goes stale. This way the presence query only invalidates when online status actually changes, not on every heartbeat.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.agents/skills/convex-performance-audit/references/subscription-cost.md around lines 170 - 172, The paragraph repeats the word "Queries" at the start of three sentences; rewrite the text to vary sentence openings while preserving meaning—locate the sentences beginning with "Queries that only need `name` and `email` no longer re-run on every heartbeat.", "Queries that actually need online status fetch the heartbeat document explicitly.", and the following sentence that starts "For an even further optimization..." and rephrase them (for example, start one sentence with "If only `name` and `email` are needed," another with "When online status is required," and rework the final sentence to introduce the `isOnline` presence-doc suggestion) so readability is improved without changing the technical guidance about using an `isOnline` flag and cron to batch-mark stale heartbeats..agents/skills/convex-performance-audit/references/hot-path-rules.md (1)
220-220: Minor grammar suggestion: hyphenate compound adjective.The phrase "high volume" should be hyphenated as "high-volume" when used as a compound adjective before a noun.
📝 Proposed fix
-- the query is high volume +- the query is high-volume🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.agents/skills/convex-performance-audit/references/hot-path-rules.md at line 220, Change the compound adjective "high volume" to "high-volume" in the document text (the sentence comparing an 800 byte summary row to a 3 KB full document on a hot page) so the phrase is correctly hyphenated when used before a noun; locate the occurrence of "high volume" in that sentence and replace it with "high-volume"..agents/skills/convex-create-component/references/local-components.md (1)
1-38: Consider reducing cross-ecosystem doc duplication.This file mirrors
.windsurf/skills/convex-create-component/references/local-components.md; maintaining one canonical source (or generation step) would lower drift risk.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.agents/skills/convex-create-component/references/local-components.md around lines 1 - 38, The "Local Convex Components" markdown (heading "Local Convex Components" and its checklist) duplicates content maintained elsewhere; consolidate by choosing a single canonical source (the other reference noted in review) and either remove this duplicate file or replace its contents with a clear pointer to the canonical document, update any README or consumer references to use the canonical location, and add or enable a generation/CI step to keep the single source in sync..claude/skills/convex-quickstart/SKILL.md (1)
104-112: Add language identifier to fenced code block.The code block showing the project structure is missing a language identifier. While this appears to be a directory tree structure, adding an identifier improves rendering and consistency.
📝 Proposed fix
-``` +```text my-app/ convex/ # Backend functions and schema _generated/ # Auto-generated types (check this into git)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.claude/skills/convex-quickstart/SKILL.md around lines 104 - 112, The fenced code block in SKILL.md that shows the project directory tree (the block starting with "my-app/" and containing "convex/", "_generated/", "schema.ts", etc.) lacks a language identifier; update that triple-backtick fence to include a language tag such as "text" (e.g., ```text) so the directory tree renders consistently..claude/skills/convex-setup-auth/references/auth0.md (1)
33-33: Tighten phrasing for a more consistent operator tone.At Line 33 and Line 72, consider replacing conversational phrasing (“If you want…”, “tell the user…”) with a more neutral instruction style to keep the reference tone consistent throughout.
✍️ Suggested wording tweak
-- Ask the user directly: "The fastest path is to install the Auth0 CLI so I can do more of this for you. If you want, I can install it and then only ask you to log in when needed. Would you like me to do that?" +- Ask the user directly: "The fastest path is to install the Auth0 CLI so I can complete more setup steps automatically. If preferred, I can install it and only prompt for login when needed. Would you like me to proceed?" ... -- 14. If login works but Convex auth or token refresh fails in a way you cannot clearly resolve, stop and tell the user to follow the official docs manually for now +- 14. If login works but Convex auth or token refresh fails in a way you cannot clearly resolve, stop and ask the user to follow the official docs manually for nowAlso applies to: 72-72
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.claude/skills/convex-setup-auth/references/auth0.md at line 33, Replace the conversational phrasings at the two occurrences ("The fastest path is to install the Auth0 CLI so I can do more of this for you. If you want, I can install it and then only ask you to log in when needed. Would you like me to do that?" and the similar “tell the user…” at the second occurrence) with neutral, operator-style instructions; for example, change them to a concise directive that offers the CLI installation as an option without informal language (e.g., "Install the Auth0 CLI to enable automated setup; I can install it and request login only when required. Proceed with installation?"). Ensure both replacements use the same neutral tone so the reference remains consistent..claude/skills/convex-performance-audit/references/subscription-cost.md (1)
170-173: Tiny readability polish in this paragraph.You can vary sentence openings here to reduce repetition and improve flow.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.claude/skills/convex-performance-audit/references/subscription-cost.md around lines 170 - 173, Rewrite the paragraph to reduce repetitive sentence openings and improve flow: keep the technical suggestions about not re-running queries that only need name/email, explicitly fetching the heartbeat document when online status is required, and the optimization of a separate presence document with an isOnline flag and cron to mark stale heartbeats offline, but vary sentence structures (e.g., start one sentence with the optimization idea, another with the implementation detail) and shorten/merge where helpful to improve readability while preserving terms like heartbeat, lastSeen, presence document, and isOnline..agents/skills/convex-setup-auth/references/auth0.md (1)
1-116: Consider a shared source for duplicated Auth0 provider guidance.This file appears effectively mirrored in the Windsurf variant, which creates update-drift risk. A generated/shared template source would reduce maintenance overhead.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.agents/skills/convex-setup-auth/references/auth0.md around lines 1 - 116, The Auth0 guidance is duplicated across the Windsurf variant causing update drift; extract the shared guidance (the content under the "Auth0" header and the "What To Do"/"Concrete Steps"/"Gotchas" sections) into a single canonical template (e.g., a shared "Auth0 provider guidance" markdown resource) and replace the mirrored copy with a short reference or include pointing to that template; update any references to convex/auth.config.ts, Auth0Provider, ConvexProviderWithAuth0, and the "Windsurf" variant to use the shared source and add a brief note in both variant files explaining where the canonical guidance lives..windsurf/skills/convex-performance-audit/references/hot-path-rules.md (1)
220-220: Minor wording polish: hyphenate compound modifier.Consider “high-volume query” for smoother readability.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.windsurf/skills/convex-performance-audit/references/hot-path-rules.md at line 220, In the sentence "An 800 byte summary row is materially cheaper than a 3 KB full document on a hot page." and any nearby occurrences of "high volume query", hyphenate the compound modifier(s) for clarity—use "high-volume query" (and consider "800-byte summary row" and "3-KB full document" if you want consistent compound hyphenation). Update those token(s) in the same paragraph or section so the phrasing reads smoothly.components/post-editor-content.tsx (4)
145-151: Usenext/imagefor the featured image.Plain
<img>skips Next.js optimization, layout stability, and triggers the@next/next/no-img-elementlint rule. Swap to<Image>(withfill+ a sized parent, or explicitwidth/height) if the source origin is configured innext.config.*.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@components/post-editor-content.tsx` around lines 145 - 151, Replace the plain <img> used to render the featured image with Next.js' Image component: import Image from "next/image", locate the JSX that checks watchedValues.featuredImage and replace the <img src={watchedValues.featuredImage} ... /> usage with <Image>, either using fill inside a positioned/sized parent (the surrounding <div className="relative group"> becomes the sized container) or by providing explicit width/height props; ensure you preserve alt and className semantics and that the image source domain is allowed in next.config.js if it’s external.
194-196: Remove commented-out title error block or re-enable it.Dead commented code is noise; either restore the title error display or delete.
- {/* {errors.title && ( - <p className="text-red-400 mt-2">{errors.title.message}</p> - )} */} + {errors.title && ( + <p className="text-red-400 mt-2">{String(errors.title.message)}</p> + )}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@components/post-editor-content.tsx` around lines 194 - 196, The commented-out title error block (the JSX that checks errors.title and renders <p className="text-red-400 mt-2">{errors.title.message}</p>) is dead code; either delete that commented block entirely or re-enable it by uncommenting so the title validation message is rendered; update the JSX near the title input in PostEditorContent (where errors.title is referenced) so validation errors are shown consistently or remove the commented lines to eliminate noise.
64-68: Loose types on props undermine TS safety.
form: anyandsetQuillRef: React.RefObject<Quill> | anyboth collapse toany, so downstream misuse (wrong field names inregister, wrong ref shape) won't be caught.-import { UseFormReturn } from "react-hook-form"; +import type { UseFormReturn, FieldValues } from "react-hook-form"; @@ -interface PostEditorContentProps { - form: any; - setQuillRef: React.RefObject<Quill> | any; - onImageUpload: (arg: string) => void; -} +interface PostEditorContentProps { + form: UseFormReturn<PostFormValues>; // import/share type from post-editor.tsx + setQuillRef: (instance: ReactQuillType | null) => void; + onImageUpload: (type: "featured" | "content") => void; +}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@components/post-editor-content.tsx` around lines 64 - 68, PostEditorContentProps uses loose any types for form and setQuillRef; replace them with concrete types to restore TS safety: change form: any to the proper react-hook-form type (e.g. UseFormReturn<FormValues> or UseFormReturn<Record<string, any>> after importing UseFormReturn from 'react-hook-form') and replace setQuillRef: React.RefObject<Quill> | any with a precise ref type such as React.RefObject<Quill> | React.MutableRefObject<Quill | null> or a callback ref signature ((instance: Quill | null) => void), and update any usages of form.register / form.watch and setQuillRef to match the chosen types; keep onImageUpload as (arg: string) => void.
15-21: Conditional CSS import is non-idiomatic in Next.js; prefer static import.Next.js natively handles
.cssimports in client components and ships them with the appropriate chunk. The conditional dynamicimport(...)insideif (typeof window !== "undefined")(a) drops the return value so the Promise is fire-and-forget with no error handling, and (b) races first render — the editor can paint before Quill's theme CSS loads.For optimal results with react-quill in Next.js 15, import the CSS in your root
app/layout.tsx(Server Component) to ensure global availability:-const ReactQuill = dynamic(() => import("react-quill-new"), { - ssr: false, -}) as unknown as typeof ReactQuillType; - -if (typeof window !== "undefined") { - import("react-quill-new/dist/quill.snow.css"); -} +const ReactQuill = dynamic(() => import("react-quill-new"), { + ssr: false, +}) as unknown as typeof ReactQuillType;Then in
app/layout.tsx:+import "react-quill-new/dist/quill.snow.css";If keeping the CSS import in this file, use a static import at the top level instead of the conditional dynamic import.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@components/post-editor-content.tsx` around lines 15 - 21, The conditional dynamic CSS import for Quill is non-idiomatic and can race rendering; replace the fire-and-forget import("react-quill-new/dist/quill.snow.css") inside the window check with a static top-level CSS import so the stylesheet is bundled and available before the ReactQuill component mounts. Either move the import into the global app/layout.tsx (preferred) or add import "react-quill-new/dist/quill.snow.css" at the top of components/post-editor-content.tsx, and remove the if (typeof window !== "undefined") { import(...) } block so ReactQuill (the dynamic import of ReactQuillType) has the theme CSS deterministically available.components/post-editor-header.tsx (1)
19-28: TighteninitialDatatyping.
initialData?: anydiscards the sharedInitialDataPropsshape already defined incomponents/post-editor.tsx. Export it and reuse here soinitialData?.status === "draft"stays type-checked and won't silently drift if the schema changes.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@components/post-editor-header.tsx` around lines 19 - 28, The PostEditorHeaderProps interface currently types initialData as any; instead export the existing InitialDataProps type from the PostEditor component and import it into this file, then change initialData?: any to initialData?: InitialDataProps so checks like initialData?.status === "draft" are type-checked; update the interface declaration (PostEditorHeaderProps) to use the imported InitialDataProps and run the typechecker to fix any resulting mismatches.hooks/use-convex-query.tsx (1)
17-31:useEffect+useStatemirror ofuseQueryresult is redundant and adds a render.
useQueryalready returns the current value (orundefinedwhile loading). Copying it into local state via an effect adds a re-render, stale reads, and thetry/catcharoundsetDatacan never actually throw (errors in Convex queries surface via an Error boundary/Convex client, not by a throwing setter). Consider deriving directly:const result = useQuery(query, ...args); return { data: result, isLoading: result === undefined, error: null };If error handling is desired, wrap
useQuerywith Convex's error utilities instead.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@hooks/use-convex-query.tsx` around lines 17 - 31, The useEffect that mirrors the Convex `useQuery` result (using `setData`, `setIsLoading`, `setError`) is redundant and should be removed: stop storing `result` in local state and remove the try/catch/finally block around `setData`, `setIsLoading`, and `setError`; instead return `data: result`, `isLoading: result === undefined`, and `error: null` directly from the hook (leave the `useQuery` call intact). Update the hook that references `result`, `setData`, `setIsLoading`, and `setError` (in hooks/use-convex-query.tsx) to use the derived values and remove the `useEffect` and related useState declarations.components/post-editor.tsx (1)
78-82: Avoiddata: any— usez.inferfor type safety.- const onSubmit = async ( - data: any, - action: string, - silent: boolean = false, - ) => { + type PostFormValues = z.infer<typeof postSchema>; + const onSubmit = async ( + data: PostFormValues, + action: "publish" | "draft" | "schedule", + silent: boolean = false, + ) => {This also makes the schedule/publish/draft mismatch on line 142 surface at compile time.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@components/post-editor.tsx` around lines 78 - 82, Replace the loose data: any in the onSubmit function with the typed Zod inference for the component's form schema (e.g., change to data: z.infer<typeof postEditorSchema>), importing the schema if needed; update any call sites and internal uses in onSubmit to match the typed shape so the schedule/publish/draft field mismatch around the publish logic in onSubmit becomes a compile-time type error and can be corrected accordingly.app/actions/gemini.ts (1)
7-11: Tightentagstyping.
tags = []is inferred asany[], which the AI summary also flagged. Since it's joined viatags.join(", "), narrow it tostring[]for type safety and better IDE feedback.Proposed fix
export async function generateBlogContent( title: string, category = "", - tags = [], + tags: string[] = [], ) {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/actions/gemini.ts` around lines 7 - 11, The parameter `tags` in generateBlogContent is currently inferred as any[]; change its type to string[] so callers and IDEs get proper type safety and so tags.join(", ") is valid—update the function signature export async function generateBlogContent(title: string, category = "", tags: string[]) { (or tags: string[] = []) and adjust any call sites if needed to pass string arrays.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.agents/skills/convex-quickstart/SKILL.md:
- Around line 104-112: The fenced code block in SKILL.md containing the
directory listing lacks a language specifier; update the backtick fence for that
snippet (the block starting with "my-app/") to include a language identifier
such as text (e.g., change ``` to ```text) or remove the language token entirely
so the directory listing is rendered correctly; locate the directory-listing
fenced block in .agents/skills/convex-quickstart/SKILL.md and modify the opening
fence accordingly.
In @.claude/skills/convex-create-component/references/advanced-patterns.md:
- Around line 119-133: The example calls getAuthUserId(ctx) but never imports or
defines it; update the example where Notifications and send/mutation are used to
either import getAuthUserId from your auth utilities or add a short
placeholder/definition (or a comment) showing it’s an app-defined helper; ensure
the reference in the send handler (function send / mutation handler) points to
the correct exported symbol so the example is self-contained and compile-ready.
In @.claude/skills/convex-create-component/SKILL.md:
- Around line 236-246: The "Bad" example around the v.id("users") usage contains
JavaScript object literal syntax errors (uses semicolons) that confuse the
intent; update the example so the object literal is valid (replace semicolons
with commas and ensure the braces and commas are correct) while preserving the
semantic point that parent-owned IDs should not use v.id("users") and instead
the boundary should use v.string() in the "Good" example; locate the snippet
containing v.id("users") and v.string() and fix the punctuation so both examples
are syntactically valid and clearly demonstrate the difference.
In @.claude/skills/convex-performance-audit/references/hot-path-rules.md:
- Line 220: The sentence "An 800 byte summary row is materially cheaper than a 3
KB full document on a hot page." needs a hyphenated compound modifier where you
refer to high volume usage — replace any instance of "high volume" in this
user-facing text with "high-volume" (e.g., update the sentence or nearby phrase
that describes high volume/hot-page scenarios) to use correct compound adjective
formatting.
In @.windsurf/skills/convex-create-component/SKILL.md:
- Around line 236-246: The "Bad" example in SKILL.md uses semicolons inside the
object literal for args (userId: v.id("users");) which causes a syntax error;
update that code block (the bad example showing args) to use a comma or no
trailing delimiter between properties (e.g., userId: v.id("users"), or just
userId: v.id("users")) so the object literal is valid JavaScript/TypeScript and
contrasts correctly with the "Good" example that uses v.string().
In @.windsurf/skills/convex-setup-auth/references/clerk.md:
- Line 49: Replace brittle session-scoped URLs that include the
"last-active?path=..." fragment (e.g., the Clerk URL "last-active?path=api-keys"
referenced on the lines noted) with stable canonical dashboard or docs links and
add a short navigation note; specifically, update occurrences of
"last-active?path=api-keys" and the similar "last-active?path=..." links to
point to Clerk's official API keys documentation or top-level dashboard URL and
append a brief instruction like "Navigate to Settings → API keys" so readers can
find the page without relying on session-scoped paths.
- Line 57: Update the guidance that currently treats CLERK_JWT_ISSUER_DOMAIN and
CLERK_FRONTEND_API_URL as interchangeable: clarify they both point to the same
underlying Clerk Frontend API URL but are distinct configuration options used in
different deployment patterns — recommend using CLERK_FRONTEND_API_URL for local
.env configuration and CLERK_JWT_ISSUER_DOMAIN for Convex dashboard/production
dashboard configuration. Edit the sentence around the reference to
CLERK_JWT_ISSUER_DOMAIN / CLERK_FRONTEND_API_URL so it explicitly states this
distinction and suggests choosing one pattern based on deployment strategy
rather than treating them as two different URLs.
In `@app/actions/gemini.ts`:
- Line 5: The code constructs GoogleGenerativeAI with an empty-string fallback
which hides a missing GEMINI_API_KEY; update the initialization to fail fast or
at least log a clear error when process.env.GEMINI_API_KEY is falsy: check
process.env.GEMINI_API_KEY before creating the GoogleGenerativeAI instance (used
by genAI) and either throw an Error or log a prominent error and exit if the key
is missing so the misconfiguration is immediately obvious.
- Line 17: The improveContent function is still selecting the deprecated
"gemini-2.0-flash" model; update it to use "gemini-2.5-flash" to match
generateBlogContent and avoid the June 1, 2026 shutdown, and to prevent future
drift extract the model name into a shared constant (e.g., MODEL_GEMINI_FLASH)
used by both improveContent and generateBlogContent and replace inline strings
or calls like genAI.getGenerativeModel({ model: "gemini-2.0-flash" }) with
genAI.getGenerativeModel({ model: MODEL_GEMINI_FLASH }).
- Around line 81-156: The improveContent function returns unsanitized model
HTML, lacks output validation and specialized API error handling, and
interpolates raw user content into the prompt (prompt-injection risk); update
improveContent to (1) validate the generated string from response.text() (e.g.,
ensure non-empty and min-length similar to generateBlogContent) and return
success:false when validation fails, (2) distinguish API/config/quota errors in
the catch block by inspecting the thrown error (e.g., error.code or
error.message) and map quota/config cases to clear error responses like
generateBlogContent does, (3) avoid direct prompt injection by escaping or
encoding currentContent before embedding it into prompt strings (used in the
switch cases and when calling model.generateContent), and (4) ensure any HTML
returned is treated as untrusted — sanitize the improvedContent before it's
persisted or passed to the editor (note: add DOMPurify or equivalent at the
caller where setValue() occurs if not sanitizing inside improveContent).
Reference symbols: improveContent, generateBlogContent, model.generateContent,
result.response/response.text(), and the catch block for error handling.
In `@app/dashboard/create/page.tsx`:
- Around line 18-20: The loader branch for isDraftLoading || isUserLoading
returns a bare BarLoader which will render as a thin bar at the top; wrap the
BarLoader in the same full-height, centered fallback container used later in the
component (the grid/place-items-center / min-height container around the
fallback UI) so the spinner occupies the main area and is vertically centered;
update the conditional branch that returns <BarLoader ... /> to return that
BarLoader wrapped in the same layout container component/markup used by the
fallback UI to ensure consistent padding and vertical centering.
In `@components/post-editor-content.tsx`:
- Around line 213-231: The dynamic Tailwind class interpolations in the Button
render (inside the array mapping that builds { type, icon: Icon, color }) won't
be picked up by Tailwind JIT; replace the template strings like
`border-${color}-500` / `text-${color}-400` / `hover:bg-${color}-500` with a
small literal class-map keyed by color (e.g., const colorClasses = { green:
"border-green-500 text-green-400 hover:bg-green-500 hover:text-white", blue:
"...", orange: "..." }) and apply colorClasses[color] to the Button's className;
update the mapping used by the JSX that renders Button (the map over
[{type,...}]) to use that classMap, keep props like onClick={() =>
handleAI("improve", type)} and disabled={isGenerating || isImproving} unchanged,
and optionally add those specific full classes to your Tailwind safelist if you
want to guarantee inclusion.
- Around line 115-133: The HTML returned by generateBlogContent / improveContent
is being injected into Quill via setValue("content", ...) without sanitization;
either sanitize the content server-side inside the Gemini action that builds the
response (use a library like DOMPurify to clean result.content before returning)
or sanitize client-side in this component immediately before calling setValue
(clean result.content then call setValue), and keep the existing success/error
handling and the setIsGenerating/setIsImproving finalization unchanged.
In `@components/post-editor-header.tsx`:
- Around line 50-55: The handler handleSchdule is misspelled and calls
onPublish() causing "Schedule for later" to publish immediately; rename/fix
handleSchdule to handleSchedule and change its body to call onSchedule()
(guarded by if (onSchedule)) instead of onPublish(), and still close the menu
via setIsPublishMenuOpen(false); also update any references/bindings (e.g., the
menu item that currently points to handleSchdule) to the corrected
handleSchedule so the onSchedule prop in components/post-editor.tsx is actually
invoked.
In `@components/post-editor.tsx`:
- Around line 137-143: The call path is ambiguous: handleSchedule passes
"schedule" but onSubmit only treats action === "publish" and falls back to
"draft"; change onSubmit's action parameter to a discriminated union type
("publish" | "draft" | "schedule") and update its logic to explicitly handle
"schedule" (e.g., set status to the intended value — if you want scheduled posts
to remain draft until cron publishes, set status = "draft" and preserve
scheduledFor; otherwise set a "scheduled" status). Update onSubmit (and any
callers like handleSchedule) to use the new union type and ensure scheduledFor
is preserved when action === "schedule". Also verify that PostEditorHeader's
onSchedule handler is actually invoked (it currently isn't) and wire its
invocation if needed.
- Around line 62-72: The defaultValues block is overwriting an existing
scheduled timestamp by calling new Date() instead of using the stored value and
it's also emitting a UTC ISO string which is wrong for a datetime-local input;
replace the scheduledFor assignment in the defaultValues object so that when
initialData?.scheduledFor is present you format that stored timestamp into a
local "YYYY-MM-DDTHH:MM" string (e.g. implement a helper like
formatLocalDatetime(date) that constructs local-year, month, day, hours and
minutes with zero-padding) and return "" when absent; update the scheduledFor
key in the defaultValues object to call that helper (reference: defaultValues,
scheduledFor).
In `@components/ui/dropdown-menu.tsx`:
- Around line 17-19: The DropdownMenuTrigger currently types an asChild prop but
simply spreads props into MenuPrimitive.Trigger, so asChild is ignored and
causes nested <button> elements; fix by implementing the render-prop behavior
used by `@base-ui/react/menu` instead of Radix's asChild: change
DropdownMenuTrigger to accept asChild?: boolean and children:
React.ReactElement, do not spread asChild into MenuPrimitive.Trigger, and when
asChild is true forward a render prop to MenuPrimitive.Trigger that
returns/merges the provided child (so the child becomes the actual trigger) and
forward the trigger props; also update the function signature/type (remove
asChild from the generic ComponentProps spread and make it explicit) and adjust
the call site in components/post-editor-header.tsx if you choose to remove
asChild instead of supporting it.
In `@hooks/use-convex-query.tsx`:
- Around line 1-6: Remove the incorrect "import Error from 'next/error'" and the
unused "mutation" import from "@/convex/_generated/server"; update any error
parameter annotations that currently read "err: Error | any" (used around the
error handlers that reference err at the two catch sites) to use a safe type
like "unknown" (e.g., "err: unknown") and narrow it where needed (e.g., if (err
instanceof Error) { toast.err.message } else { toast(String(err)) }) so you use
the built-in Error runtime type rather than the Next.js component and eliminate
the unnecessary import.
---
Nitpick comments:
In @.agents/skills/convex-create-component/references/local-components.md:
- Around line 1-38: The "Local Convex Components" markdown (heading "Local
Convex Components" and its checklist) duplicates content maintained elsewhere;
consolidate by choosing a single canonical source (the other reference noted in
review) and either remove this duplicate file or replace its contents with a
clear pointer to the canonical document, update any README or consumer
references to use the canonical location, and add or enable a generation/CI step
to keep the single source in sync.
In @.agents/skills/convex-performance-audit/references/hot-path-rules.md:
- Line 220: Change the compound adjective "high volume" to "high-volume" in the
document text (the sentence comparing an 800 byte summary row to a 3 KB full
document on a hot page) so the phrase is correctly hyphenated when used before a
noun; locate the occurrence of "high volume" in that sentence and replace it
with "high-volume".
In @.agents/skills/convex-performance-audit/references/subscription-cost.md:
- Around line 170-172: The paragraph repeats the word "Queries" at the start of
three sentences; rewrite the text to vary sentence openings while preserving
meaning—locate the sentences beginning with "Queries that only need `name` and
`email` no longer re-run on every heartbeat.", "Queries that actually need
online status fetch the heartbeat document explicitly.", and the following
sentence that starts "For an even further optimization..." and rephrase them
(for example, start one sentence with "If only `name` and `email` are needed,"
another with "When online status is required," and rework the final sentence to
introduce the `isOnline` presence-doc suggestion) so readability is improved
without changing the technical guidance about using an `isOnline` flag and cron
to batch-mark stale heartbeats.
In @.agents/skills/convex-setup-auth/references/auth0.md:
- Around line 1-116: The Auth0 guidance is duplicated across the Windsurf
variant causing update drift; extract the shared guidance (the content under the
"Auth0" header and the "What To Do"/"Concrete Steps"/"Gotchas" sections) into a
single canonical template (e.g., a shared "Auth0 provider guidance" markdown
resource) and replace the mirrored copy with a short reference or include
pointing to that template; update any references to convex/auth.config.ts,
Auth0Provider, ConvexProviderWithAuth0, and the "Windsurf" variant to use the
shared source and add a brief note in both variant files explaining where the
canonical guidance lives.
In @.claude/skills/convex-performance-audit/agents/openai.yaml:
- Around line 1-10: The agent YAML duplicates top-level interface fields
(display_name, short_description, icon_small, icon_large, brand_color,
default_prompt, policy.allow_implicit_invocation) across ecosystems; create a
single source-of-truth template (e.g., a canonical agent template or JSON/YAML
schema) and replace this file with a generated artifact: add a small generation
script or makefile target that emits
.claude/skills/convex-performance-audit/agents/openai.yaml from the template,
update CI to run a validation/generation step (or fail if out-of-date), and
refactor any build or repo docs to point to the canonical template so the keys
above are kept in sync automatically.
In @.claude/skills/convex-performance-audit/references/occ-conflicts.md:
- Around line 1-114: Duplicate OCC conflict reference files exist (two identical
copies), causing maintenance overhead; remove one copy and consolidate to a
single canonical reference, update any consumers to point to that canonical
file, and optionally replace the removed copy with a symlink or a shared
docs/include mechanism so future edits are made once. Ensure the canonical file
(occ-conflicts.md) remains in the shared references location used by both agent
ecosystems and update any documentation/build/config that referenced the removed
duplicate to use the canonical path.
In @.claude/skills/convex-performance-audit/references/subscription-cost.md:
- Around line 170-173: Rewrite the paragraph to reduce repetitive sentence
openings and improve flow: keep the technical suggestions about not re-running
queries that only need name/email, explicitly fetching the heartbeat document
when online status is required, and the optimization of a separate presence
document with an isOnline flag and cron to mark stale heartbeats offline, but
vary sentence structures (e.g., start one sentence with the optimization idea,
another with the implementation detail) and shorten/merge where helpful to
improve readability while preserving terms like heartbeat, lastSeen, presence
document, and isOnline.
In @.claude/skills/convex-quickstart/SKILL.md:
- Around line 104-112: The fenced code block in SKILL.md that shows the project
directory tree (the block starting with "my-app/" and containing "convex/",
"_generated/", "schema.ts", etc.) lacks a language identifier; update that
triple-backtick fence to include a language tag such as "text" (e.g., ```text)
so the directory tree renders consistently.
In @.claude/skills/convex-setup-auth/references/auth0.md:
- Line 33: Replace the conversational phrasings at the two occurrences ("The
fastest path is to install the Auth0 CLI so I can do more of this for you. If
you want, I can install it and then only ask you to log in when needed. Would
you like me to do that?" and the similar “tell the user…” at the second
occurrence) with neutral, operator-style instructions; for example, change them
to a concise directive that offers the CLI installation as an option without
informal language (e.g., "Install the Auth0 CLI to enable automated setup; I can
install it and request login only when required. Proceed with installation?").
Ensure both replacements use the same neutral tone so the reference remains
consistent.
In @.windsurf/skills/convex-performance-audit/references/hot-path-rules.md:
- Line 220: In the sentence "An 800 byte summary row is materially cheaper than
a 3 KB full document on a hot page." and any nearby occurrences of "high volume
query", hyphenate the compound modifier(s) for clarity—use "high-volume query"
(and consider "800-byte summary row" and "3-KB full document" if you want
consistent compound hyphenation). Update those token(s) in the same paragraph or
section so the phrasing reads smoothly.
In @.windsurf/skills/convex-performance-audit/references/subscription-cost.md:
- Around line 170-172: Reword the three consecutive sentences that start with
"Queries" to improve readability: locate the sentences beginning "Queries that
only need `name` and `email` no longer re-run on every heartbeat," "Queries that
actually need online status fetch the heartbeat document explicitly," and the
sentence proposing the `isOnline` presence document, then vary the sentence
openings (for example, start the second sentence with "When online status is
required, ..." and the third with "For an additional optimization, ...") while
preserving the original meaning and the referenced terms (`name`, `email`,
`heartbeat document`, `isOnline` flag).
In `@app/actions/gemini.ts`:
- Around line 7-11: The parameter `tags` in generateBlogContent is currently
inferred as any[]; change its type to string[] so callers and IDEs get proper
type safety and so tags.join(", ") is valid—update the function signature export
async function generateBlogContent(title: string, category = "", tags: string[])
{ (or tags: string[] = []) and adjust any call sites if needed to pass string
arrays.
In `@components/post-editor-content.tsx`:
- Around line 145-151: Replace the plain <img> used to render the featured image
with Next.js' Image component: import Image from "next/image", locate the JSX
that checks watchedValues.featuredImage and replace the <img
src={watchedValues.featuredImage} ... /> usage with <Image>, either using fill
inside a positioned/sized parent (the surrounding <div className="relative
group"> becomes the sized container) or by providing explicit width/height
props; ensure you preserve alt and className semantics and that the image source
domain is allowed in next.config.js if it’s external.
- Around line 194-196: The commented-out title error block (the JSX that checks
errors.title and renders <p className="text-red-400
mt-2">{errors.title.message}</p>) is dead code; either delete that commented
block entirely or re-enable it by uncommenting so the title validation message
is rendered; update the JSX near the title input in PostEditorContent (where
errors.title is referenced) so validation errors are shown consistently or
remove the commented lines to eliminate noise.
- Around line 64-68: PostEditorContentProps uses loose any types for form and
setQuillRef; replace them with concrete types to restore TS safety: change form:
any to the proper react-hook-form type (e.g. UseFormReturn<FormValues> or
UseFormReturn<Record<string, any>> after importing UseFormReturn from
'react-hook-form') and replace setQuillRef: React.RefObject<Quill> | any with a
precise ref type such as React.RefObject<Quill> | React.MutableRefObject<Quill |
null> or a callback ref signature ((instance: Quill | null) => void), and update
any usages of form.register / form.watch and setQuillRef to match the chosen
types; keep onImageUpload as (arg: string) => void.
- Around line 15-21: The conditional dynamic CSS import for Quill is
non-idiomatic and can race rendering; replace the fire-and-forget
import("react-quill-new/dist/quill.snow.css") inside the window check with a
static top-level CSS import so the stylesheet is bundled and available before
the ReactQuill component mounts. Either move the import into the global
app/layout.tsx (preferred) or add import "react-quill-new/dist/quill.snow.css"
at the top of components/post-editor-content.tsx, and remove the if (typeof
window !== "undefined") { import(...) } block so ReactQuill (the dynamic import
of ReactQuillType) has the theme CSS deterministically available.
In `@components/post-editor-header.tsx`:
- Around line 19-28: The PostEditorHeaderProps interface currently types
initialData as any; instead export the existing InitialDataProps type from the
PostEditor component and import it into this file, then change initialData?: any
to initialData?: InitialDataProps so checks like initialData?.status === "draft"
are type-checked; update the interface declaration (PostEditorHeaderProps) to
use the imported InitialDataProps and run the typechecker to fix any resulting
mismatches.
In `@components/post-editor.tsx`:
- Around line 78-82: Replace the loose data: any in the onSubmit function with
the typed Zod inference for the component's form schema (e.g., change to data:
z.infer<typeof postEditorSchema>), importing the schema if needed; update any
call sites and internal uses in onSubmit to match the typed shape so the
schedule/publish/draft field mismatch around the publish logic in onSubmit
becomes a compile-time type error and can be corrected accordingly.
In `@hooks/use-convex-query.tsx`:
- Around line 17-31: The useEffect that mirrors the Convex `useQuery` result
(using `setData`, `setIsLoading`, `setError`) is redundant and should be
removed: stop storing `result` in local state and remove the try/catch/finally
block around `setData`, `setIsLoading`, and `setError`; instead return `data:
result`, `isLoading: result === undefined`, and `error: null` directly from the
hook (leave the `useQuery` call intact). Update the hook that references
`result`, `setData`, `setIsLoading`, and `setError` (in
hooks/use-convex-query.tsx) to use the derived values and remove the `useEffect`
and related useState declarations.
In `@README.md`:
- Line 1: The README header uses "Full Stack" as a compound adjective; update it
to "Full-Stack" to read "Full-Stack AI Content Platform using Next JS, Tailwind,
React Quill, ImageKit, Shadcn UI, Clerk and Convex" (search for the title string
in README.md and replace the unhyphenated form; also scan for other occurrences
of "Full Stack" and hyphenate them consistently).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e623bfac-b586-45ce-b19e-f151a69409de
⛔ Files ignored due to path filters (19)
.agents/skills/convex-create-component/assets/icon.svgis excluded by!**/*.svg.agents/skills/convex-migration-helper/assets/icon.svgis excluded by!**/*.svg.agents/skills/convex-performance-audit/assets/icon.svgis excluded by!**/*.svg.agents/skills/convex-quickstart/assets/icon.svgis excluded by!**/*.svg.agents/skills/convex-setup-auth/assets/icon.svgis excluded by!**/*.svg.claude/skills/convex-create-component/assets/icon.svgis excluded by!**/*.svg.claude/skills/convex-migration-helper/assets/icon.svgis excluded by!**/*.svg.claude/skills/convex-performance-audit/assets/icon.svgis excluded by!**/*.svg.claude/skills/convex-quickstart/assets/icon.svgis excluded by!**/*.svg.claude/skills/convex-setup-auth/assets/icon.svgis excluded by!**/*.svg.windsurf/skills/convex-create-component/assets/icon.svgis excluded by!**/*.svg.windsurf/skills/convex-migration-helper/assets/icon.svgis excluded by!**/*.svg.windsurf/skills/convex-performance-audit/assets/icon.svgis excluded by!**/*.svg.windsurf/skills/convex-quickstart/assets/icon.svgis excluded by!**/*.svg.windsurf/skills/convex-setup-auth/assets/icon.svgis excluded by!**/*.svgapp/favicon.icois excluded by!**/*.icoconvex/_generated/ai/ai-files.state.jsonis excluded by!**/_generated/**convex/_generated/ai/guidelines.mdis excluded by!**/_generated/**package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (86)
.agents/skills/convex-create-component/SKILL.md.agents/skills/convex-create-component/agents/openai.yaml.agents/skills/convex-create-component/references/advanced-patterns.md.agents/skills/convex-create-component/references/hybrid-components.md.agents/skills/convex-create-component/references/local-components.md.agents/skills/convex-create-component/references/packaged-components.md.agents/skills/convex-migration-helper/SKILL.md.agents/skills/convex-migration-helper/agents/openai.yaml.agents/skills/convex-migration-helper/references/migration-patterns.md.agents/skills/convex-migration-helper/references/migrations-component.md.agents/skills/convex-performance-audit/SKILL.md.agents/skills/convex-performance-audit/agents/openai.yaml.agents/skills/convex-performance-audit/references/function-budget.md.agents/skills/convex-performance-audit/references/hot-path-rules.md.agents/skills/convex-performance-audit/references/occ-conflicts.md.agents/skills/convex-performance-audit/references/subscription-cost.md.agents/skills/convex-quickstart/SKILL.md.agents/skills/convex-quickstart/agents/openai.yaml.agents/skills/convex-setup-auth/SKILL.md.agents/skills/convex-setup-auth/agents/openai.yaml.agents/skills/convex-setup-auth/references/auth0.md.agents/skills/convex-setup-auth/references/clerk.md.agents/skills/convex-setup-auth/references/convex-auth.md.agents/skills/convex-setup-auth/references/workos-authkit.md.agents/skills/convex/SKILL.md.claude/skills/convex-create-component/SKILL.md.claude/skills/convex-create-component/agents/openai.yaml.claude/skills/convex-create-component/references/advanced-patterns.md.claude/skills/convex-create-component/references/hybrid-components.md.claude/skills/convex-create-component/references/local-components.md.claude/skills/convex-create-component/references/packaged-components.md.claude/skills/convex-migration-helper/SKILL.md.claude/skills/convex-migration-helper/agents/openai.yaml.claude/skills/convex-migration-helper/references/migration-patterns.md.claude/skills/convex-migration-helper/references/migrations-component.md.claude/skills/convex-performance-audit/SKILL.md.claude/skills/convex-performance-audit/agents/openai.yaml.claude/skills/convex-performance-audit/references/function-budget.md.claude/skills/convex-performance-audit/references/hot-path-rules.md.claude/skills/convex-performance-audit/references/occ-conflicts.md.claude/skills/convex-performance-audit/references/subscription-cost.md.claude/skills/convex-quickstart/SKILL.md.claude/skills/convex-quickstart/agents/openai.yaml.claude/skills/convex-setup-auth/SKILL.md.claude/skills/convex-setup-auth/agents/openai.yaml.claude/skills/convex-setup-auth/references/auth0.md.claude/skills/convex-setup-auth/references/clerk.md.claude/skills/convex-setup-auth/references/convex-auth.md.claude/skills/convex-setup-auth/references/workos-authkit.md.claude/skills/convex/SKILL.md.windsurf/skills/convex-create-component/SKILL.md.windsurf/skills/convex-create-component/agents/openai.yaml.windsurf/skills/convex-create-component/references/advanced-patterns.md.windsurf/skills/convex-create-component/references/hybrid-components.md.windsurf/skills/convex-create-component/references/local-components.md.windsurf/skills/convex-create-component/references/packaged-components.md.windsurf/skills/convex-migration-helper/SKILL.md.windsurf/skills/convex-migration-helper/agents/openai.yaml.windsurf/skills/convex-migration-helper/references/migration-patterns.md.windsurf/skills/convex-migration-helper/references/migrations-component.md.windsurf/skills/convex-performance-audit/SKILL.md.windsurf/skills/convex-performance-audit/agents/openai.yaml.windsurf/skills/convex-performance-audit/references/function-budget.md.windsurf/skills/convex-performance-audit/references/hot-path-rules.md.windsurf/skills/convex-performance-audit/references/occ-conflicts.md.windsurf/skills/convex-performance-audit/references/subscription-cost.md.windsurf/skills/convex-quickstart/SKILL.md.windsurf/skills/convex-quickstart/agents/openai.yaml.windsurf/skills/convex-setup-auth/SKILL.md.windsurf/skills/convex-setup-auth/agents/openai.yaml.windsurf/skills/convex-setup-auth/references/auth0.md.windsurf/skills/convex-setup-auth/references/clerk.md.windsurf/skills/convex-setup-auth/references/convex-auth.md.windsurf/skills/convex-setup-auth/references/workos-authkit.md.windsurf/skills/convex/SKILL.mdREADME.mdapp/actions/gemini.tsapp/dashboard/create/page.tsxapp/dashboard/layout.tsxcomponents/post-editor-content.tsxcomponents/post-editor-header.tsxcomponents/post-editor.tsxcomponents/ui/dropdown-menu.tsxhooks/use-convex-query.tsxpackage.jsonskills-lock.json
Comment on lines
+104
to
+112
| ``` | ||
| my-app/ | ||
| convex/ # Backend functions and schema | ||
| _generated/ # Auto-generated types (check this into git) | ||
| schema.ts # Database schema (if template includes one) | ||
| src/ # Frontend code (or app/ for Next.js) | ||
| package.json | ||
| .env.local # CONVEX_URL / VITE_CONVEX_URL / NEXT_PUBLIC_CONVEX_URL | ||
| ``` |
There was a problem hiding this comment.
Add language specifier to fenced code block.
The code block showing the project structure should have a language identifier. Use text or remove the language altogether for plain directory listings.
📝 Proposed fix
-```
+```text
my-app/
convex/ # Backend functions and schema
_generated/ # Auto-generated types (check this into git)🧰 Tools
🪛 markdownlint-cli2 (0.22.0)
[warning] 104-104: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.agents/skills/convex-quickstart/SKILL.md around lines 104 - 112, The fenced
code block in SKILL.md containing the directory listing lacks a language
specifier; update the backtick fence for that snippet (the block starting with
"my-app/") to include a language identifier such as text (e.g., change ``` to
```text) or remove the language token entirely so the directory listing is
rendered correctly; locate the directory-listing fenced block in
.agents/skills/convex-quickstart/SKILL.md and modify the opening fence
accordingly.
Comment on lines
+119
to
+133
| // App usage | ||
| import { Notifications } from "@convex-dev/notifications"; | ||
| import { components } from "./_generated/api"; | ||
|
|
||
| const notifications = new Notifications(components.notifications, { | ||
| defaultChannel: "alerts", | ||
| }); | ||
|
|
||
| export const send = mutation({ | ||
| args: { message: v.string() }, | ||
| handler: async (ctx, args) => { | ||
| const userId = await getAuthUserId(ctx); | ||
| await notifications.send(ctx, { userId, message: args.message }); | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Missing import or definition for getAuthUserId.
Line 130 references getAuthUserId(ctx) but this function is neither imported nor defined in the example. Either add the import statement or provide context that this is assumed to be defined elsewhere in the app.
📝 Suggested clarification
Add a comment indicating the function is app-defined:
export const send = mutation({
args: { message: v.string() },
handler: async (ctx, args) => {
+ // Assumes getAuthUserId is defined in your app
const userId = await getAuthUserId(ctx);
await notifications.send(ctx, { userId, message: args.message });
},
});📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| // App usage | |
| import { Notifications } from "@convex-dev/notifications"; | |
| import { components } from "./_generated/api"; | |
| const notifications = new Notifications(components.notifications, { | |
| defaultChannel: "alerts", | |
| }); | |
| export const send = mutation({ | |
| args: { message: v.string() }, | |
| handler: async (ctx, args) => { | |
| const userId = await getAuthUserId(ctx); | |
| await notifications.send(ctx, { userId, message: args.message }); | |
| }, | |
| }); | |
| // App usage | |
| import { Notifications } from "@convex-dev/notifications"; | |
| import { components } from "./_generated/api"; | |
| const notifications = new Notifications(components.notifications, { | |
| defaultChannel: "alerts", | |
| }); | |
| export const send = mutation({ | |
| args: { message: v.string() }, | |
| handler: async (ctx, args) => { | |
| // Assumes getAuthUserId is defined in your app | |
| const userId = await getAuthUserId(ctx); | |
| await notifications.send(ctx, { userId, message: args.message }); | |
| }, | |
| }); |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.claude/skills/convex-create-component/references/advanced-patterns.md
around lines 119 - 133, The example calls getAuthUserId(ctx) but never imports
or defines it; update the example where Notifications and send/mutation are used
to either import getAuthUserId from your auth utilities or add a short
placeholder/definition (or a comment) showing it’s an app-defined helper; ensure
the reference in the send handler (function send / mutation handler) points to
the correct exported symbol so the example is self-contained and compile-ready.
Comment on lines
+236
to
+246
| // Bad: parent app table IDs are not valid component validators | ||
| args: { | ||
| userId: v.id("users"); | ||
| } | ||
| ``` | ||
|
|
||
| ```ts | ||
| // Good: treat parent-owned IDs as strings at the boundary | ||
| args: { | ||
| userId: v.string(); | ||
| } |
There was a problem hiding this comment.
Fix syntax errors in "bad" example code.
The "bad" example demonstrates an incorrect pattern (using v.id("users") for parent app tables in component args), but the code also contains syntax errors (semicolons instead of commas in the object literal). This makes it unclear whether the issue being demonstrated is the semantic pattern or the syntax.
🔧 Proposed fix
// Bad: parent app table IDs are not valid component validators
args: {
- userId: v.id("users");
+ userId: v.id("users"), // ❌ Component has no access to app's "users" table
} // Good: treat parent-owned IDs as strings at the boundary
args: {
- userId: v.string();
+ userId: v.string(),
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| // Bad: parent app table IDs are not valid component validators | |
| args: { | |
| userId: v.id("users"); | |
| } | |
| ``` | |
| ```ts | |
| // Good: treat parent-owned IDs as strings at the boundary | |
| args: { | |
| userId: v.string(); | |
| } | |
| // Bad: parent app table IDs are not valid component validators | |
| args: { | |
| userId: v.id("users"), // ❌ Component has no access to app's "users" table | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.claude/skills/convex-create-component/SKILL.md around lines 236 - 246, The
"Bad" example around the v.id("users") usage contains JavaScript object literal
syntax errors (uses semicolons) that confuse the intent; update the example so
the object literal is valid (replace semicolons with commas and ensure the
braces and commas are correct) while preserving the semantic point that
parent-owned IDs should not use v.id("users") and instead the boundary should
use v.string() in the "Good" example; locate the snippet containing
v.id("users") and v.string() and fix the punctuation so both examples are
syntactically valid and clearly demonstrate the difference.
| - source documents are large | ||
| - the query is high volume | ||
|
|
||
| An 800 byte summary row is materially cheaper than a 3 KB full document on a hot page. |
There was a problem hiding this comment.
Use hyphenated compound modifier in user-facing text.
At Line 220, use “high-volume” for correct compound adjective formatting.
✏️ Suggested wording tweak
-- the query is high volume
+- the query is high-volume🧰 Tools
🪛 LanguageTool
[grammar] ~220-~220: Use a hyphen to join words.
Context: ...large - the query is high volume An 800 byte summary row is materially cheaper t...
(QB_NEW_EN_HYPHEN)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.claude/skills/convex-performance-audit/references/hot-path-rules.md at line
220, The sentence "An 800 byte summary row is materially cheaper than a 3 KB
full document on a hot page." needs a hyphenated compound modifier where you
refer to high volume usage — replace any instance of "high volume" in this
user-facing text with "high-volume" (e.g., update the sentence or nearby phrase
that describes high volume/hot-page scenarios) to use correct compound adjective
formatting.
Comment on lines
+236
to
+246
| // Bad: parent app table IDs are not valid component validators | ||
| args: { | ||
| userId: v.id("users"); | ||
| } | ||
| ``` | ||
|
|
||
| ```ts | ||
| // Good: treat parent-owned IDs as strings at the boundary | ||
| args: { | ||
| userId: v.string(); | ||
| } |
There was a problem hiding this comment.
Fix syntax errors in the "bad example" code block.
The code example has semicolons instead of commas in the object literal, which would cause a syntax error if copied.
🐛 Proposed fix
// Bad: parent app table IDs are not valid component validators
args: {
- userId: v.id("users");
+ userId: v.id("users"),
} // Good: treat parent-owned IDs as strings at the boundary
args: {
- userId: v.string();
+ userId: v.string(),
}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.windsurf/skills/convex-create-component/SKILL.md around lines 236 - 246,
The "Bad" example in SKILL.md uses semicolons inside the object literal for args
(userId: v.id("users");) which causes a syntax error; update that code block
(the bad example showing args) to use a comma or no trailing delimiter between
properties (e.g., userId: v.id("users"), or just userId: v.id("users")) so the
object literal is valid JavaScript/TypeScript and contrasts correctly with the
"Good" example that uses v.string().
Comment on lines
+50
to
+55
| const handleSchdule = () => { | ||
| if (onPublish) { | ||
| onPublish(); | ||
| setIsPublishMenuOpen(false); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Critical: "Schedule for later" publishes immediately instead of scheduling.
handleSchdule (also a typo for handleSchedule) calls onPublish(), not onSchedule(). As a result, clicking "Schedule for later" on line 146 triggers an immediate publish, completely bypassing the schedule flow wired up in components/post-editor.tsx (line 154, onSchedule={handleSchedule}). The onSchedule prop is currently dead code.
🐛 Fix
- const handleSchdule = () => {
- if (onPublish) {
- onPublish();
- setIsPublishMenuOpen(false);
- }
- };
+ const handleSchedule = () => {
+ onSchedule();
+ setIsPublishMenuOpen(false);
+ };
@@
- <DropdownMenuItem
- onClick={handleSchdule}
- >
+ <DropdownMenuItem onClick={handleSchedule}>Also applies to: 145-150
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@components/post-editor-header.tsx` around lines 50 - 55, The handler
handleSchdule is misspelled and calls onPublish() causing "Schedule for later"
to publish immediately; rename/fix handleSchdule to handleSchedule and change
its body to call onSchedule() (guarded by if (onSchedule)) instead of
onPublish(), and still close the menu via setIsPublishMenuOpen(false); also
update any references/bindings (e.g., the menu item that currently points to
handleSchdule) to the corrected handleSchedule so the onSchedule prop in
components/post-editor.tsx is actually invoked.
Comment on lines
+62
to
+72
| defaultValues: { | ||
| title: initialData?.title || "", | ||
| content: initialData?.content || "", | ||
| category: initialData?.category || "", | ||
| tags: initialData?.tags || [], | ||
| featuredImage: initialData?.featuredImage || "", | ||
| scheduledFor: initialData?.scheduledFor | ||
| ? new Date().toISOString().slice(0, 16) | ||
| : "", | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Bug: existing scheduledFor is reset to "now" instead of its stored value.
When initialData.scheduledFor is truthy, the default value uses new Date().toISOString() (current time) rather than the stored timestamp. Editing a scheduled draft silently rewrites the schedule to "now".
🐛 Fix
- scheduledFor: initialData?.scheduledFor
- ? new Date().toISOString().slice(0, 16)
- : "",
+ scheduledFor: initialData?.scheduledFor
+ ? new Date(initialData.scheduledFor).toISOString().slice(0, 16)
+ : "",Also note that datetime-local inputs expect local time, not UTC ISO — toISOString() applies UTC which can show the wrong wall-clock time depending on the user's timezone. Consider formatting with local components.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| defaultValues: { | |
| title: initialData?.title || "", | |
| content: initialData?.content || "", | |
| category: initialData?.category || "", | |
| tags: initialData?.tags || [], | |
| featuredImage: initialData?.featuredImage || "", | |
| scheduledFor: initialData?.scheduledFor | |
| ? new Date().toISOString().slice(0, 16) | |
| : "", | |
| }, | |
| }); | |
| defaultValues: { | |
| title: initialData?.title || "", | |
| content: initialData?.content || "", | |
| category: initialData?.category || "", | |
| tags: initialData?.tags || [], | |
| featuredImage: initialData?.featuredImage || "", | |
| scheduledFor: initialData?.scheduledFor | |
| ? new Date(initialData.scheduledFor).toISOString().slice(0, 16) | |
| : "", | |
| }, |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@components/post-editor.tsx` around lines 62 - 72, The defaultValues block is
overwriting an existing scheduled timestamp by calling new Date() instead of
using the stored value and it's also emitting a UTC ISO string which is wrong
for a datetime-local input; replace the scheduledFor assignment in the
defaultValues object so that when initialData?.scheduledFor is present you
format that stored timestamp into a local "YYYY-MM-DDTHH:MM" string (e.g.
implement a helper like formatLocalDatetime(date) that constructs local-year,
month, day, hours and minutes with zero-padding) and return "" when absent;
update the scheduledFor key in the defaultValues object to call that helper
(reference: defaultValues, scheduledFor).
Comment on lines
+137
to
+143
| const handleSchedule = () => { | ||
| if (!watchedValues.scheduledFor) { | ||
| toast.error("Please select a date and time to schedule"); | ||
| return; | ||
| } | ||
| handleSubmit((data) => onSubmit(data, "schedule"))(); | ||
| }; |
There was a problem hiding this comment.
handleSchedule passes "schedule" but onSubmit only recognizes "publish".
onSubmit sets status based on action === "publish"; any other value (including "schedule") becomes "draft". If scheduling a post should produce status: "draft" with scheduledFor set (i.e., awaiting a cron to publish), this is fine — but confirm intent, and make onSubmit's action parameter a discriminated union ("publish" | "draft" | "schedule") so this stays explicit.
Additionally, note that onSchedule is never actually invoked by PostEditorHeader today (see separate finding in post-editor-header.tsx).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@components/post-editor.tsx` around lines 137 - 143, The call path is
ambiguous: handleSchedule passes "schedule" but onSubmit only treats action ===
"publish" and falls back to "draft"; change onSubmit's action parameter to a
discriminated union type ("publish" | "draft" | "schedule") and update its logic
to explicitly handle "schedule" (e.g., set status to the intended value — if you
want scheduled posts to remain draft until cron publishes, set status = "draft"
and preserve scheduledFor; otherwise set a "scheduled" status). Update onSubmit
(and any callers like handleSchedule) to use the new union type and ensure
scheduledFor is preserved when action === "schedule". Also verify that
PostEditorHeader's onSchedule handler is actually invoked (it currently isn't)
and wire its invocation if needed.
Comment on lines
+17
to
19
| function DropdownMenuTrigger({ ...props }: React.ComponentProps<typeof MenuPrimitive.Trigger> & { asChild?: boolean }) { | ||
| return <MenuPrimitive.Trigger data-slot="dropdown-menu-trigger" {...props} /> | ||
| } |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
@base-ui/react Menu.Trigger asChild or render prop pattern
💡 Result:
In @base-ui/react Menu, there is no asChild prop. Instead, use the render prop pattern on Menu.Trigger to compose with custom React components or override the default rendered element (a button). Example from official docs: <Menu.Trigger render={}> Open menu </Menu.Trigger> The custom component must forward the ref and spread received props. For performance-sensitive cases, use a render function: <Menu.Trigger render={(props, state) => <MyButton {...props} size="md" />}> Open menu </Menu.Trigger> This replaces Radix UI's asChild + Slot approach. Base UI uses useRender hook internally for this composition.
Citations:
- 1: https://base-ui.com/react/components/menu
- 2: https://base-ui.com/react/handbook/composition
- 3: https://base-ui.com/react/handbook/composition.md
- 4: https://base-ui.com/react/utils/use-render
🏁 Script executed:
# First, let's find and read the dropdown-menu.tsx file
find . -name "dropdown-menu.tsx" -type fRepository: rebel600/muse
Length of output: 90
🏁 Script executed:
# Let's also search for post-editor-header.tsx
find . -name "post-editor-header.tsx" -type fRepository: rebel600/muse
Length of output: 92
🏁 Script executed:
# Search for MenuPrimitive import to understand the dependency
rg "MenuPrimitive" --type ts --type tsx -A 3 -B 3Repository: rebel600/muse
Length of output: 84
🏁 Script executed:
cat -n ./components/ui/dropdown-menu.tsxRepository: rebel600/muse
Length of output: 10711
🏁 Script executed:
# Check around line 130 in post-editor-header.tsx
sed -n '120,140p' ./components/post-editor-header.tsx | cat -nRepository: rebel600/muse
Length of output: 950
🏁 Script executed:
# Find where MenuPrimitive is imported from
rg "import.*MenuPrimitive" -A 2Repository: rebel600/muse
Length of output: 246
asChild is accepted in types but not honored by Base UI — produces nested <button> markup.
MenuPrimitive.Trigger (from @base-ui/react/menu) uses the render prop pattern, not Radix's asChild. The type signature declares asChild?: boolean on line 17 but the implementation spreads {...props} directly without handling it, causing the prop to be silently ignored. components/post-editor-header.tsx (line 130) uses <DropdownMenuTrigger asChild> expecting it to merge a <Button> component, but instead renders a <button> (MenuPrimitive's default) wrapping the Button, creating invalid nested buttons and breaking focus/a11y semantics.
Implement the render prop forwarding or remove asChild from the API and refactor the call site to not use it.
🛠️ Possible fix
-function DropdownMenuTrigger({ ...props }: React.ComponentProps<typeof MenuPrimitive.Trigger> & { asChild?: boolean }) {
- return <MenuPrimitive.Trigger data-slot="dropdown-menu-trigger" {...props} />
+function DropdownMenuTrigger({
+ asChild,
+ children,
+ ...props
+}: React.ComponentProps<typeof MenuPrimitive.Trigger> & { asChild?: boolean }) {
+ return (
+ <MenuPrimitive.Trigger
+ data-slot="dropdown-menu-trigger"
+ {...(asChild
+ ? { render: children as React.ReactElement }
+ : { children })}
+ {...props}
+ />
+ )
}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@components/ui/dropdown-menu.tsx` around lines 17 - 19, The
DropdownMenuTrigger currently types an asChild prop but simply spreads props
into MenuPrimitive.Trigger, so asChild is ignored and causes nested <button>
elements; fix by implementing the render-prop behavior used by
`@base-ui/react/menu` instead of Radix's asChild: change DropdownMenuTrigger to
accept asChild?: boolean and children: React.ReactElement, do not spread asChild
into MenuPrimitive.Trigger, and when asChild is true forward a render prop to
MenuPrimitive.Trigger that returns/merges the provided child (so the child
becomes the actual trigger) and forward the trigger props; also update the
function signature/type (remove asChild from the generic ComponentProps spread
and make it explicit) and adjust the call site in
components/post-editor-header.tsx if you choose to remove asChild instead of
supporting it.
Comment on lines
1
to
6
| import { mutation } from "@/convex/_generated/server"; | ||
| import { useMutation, useQuery } from "convex/react"; | ||
| import { FunctionReference } from "convex/server"; | ||
| import type { FunctionReference } from "convex/server"; | ||
| import Error from "next/error"; | ||
| import { useEffect, useState } from "react"; | ||
| import { toast } from "sonner"; |
There was a problem hiding this comment.
Incorrect Error import and unused mutation import.
import Error from "next/error" imports Next's Error component and then uses it as a TypeScript type on lines 24 and 50 (err: Error | any). This shadows the global Error builtin with a React component type, and | any widens the whole annotation to any anyway. The mutation import from @/convex/_generated/server is also unused.
🧹 Cleanup
-import { mutation } from "@/convex/_generated/server";
import { useMutation, useQuery } from "convex/react";
import type { FunctionReference } from "convex/server";
-import Error from "next/error";
import { useEffect, useState } from "react";
import { toast } from "sonner";
@@
- } catch (err: Error | any) {
+ } catch (err: unknown) {
+ const message = err instanceof Error ? err.message : "An error occurred while fetching data.";
setError(err);
- toast.error(err.message || "An error occurred while fetching data.");
+ toast.error(message);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@hooks/use-convex-query.tsx` around lines 1 - 6, Remove the incorrect "import
Error from 'next/error'" and the unused "mutation" import from
"@/convex/_generated/server"; update any error parameter annotations that
currently read "err: Error | any" (used around the error handlers that reference
err at the two catch sites) to use a safe type like "unknown" (e.g., "err:
unknown") and narrow it where needed (e.g., if (err instanceof Error) {
toast.err.message } else { toast(String(err)) }) so you use the built-in Error
runtime type rather than the Next.js component and eliminate the unnecessary
import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit