Eliminate the strange overhang when use Valley staircasing with All Blocks or All Double mode#200
Open
sarunint wants to merge 1 commit intorebane2001:masterfrom
Open
Eliminate the strange overhang when use Valley staircasing with All Blocks or All Double mode#200sarunint wants to merge 1 commit intorebane2001:masterfrom
sarunint wants to merge 1 commit intorebane2001:masterfrom
Conversation
sarunint
force-pushed
the
overhang
branch
2 times, most recently
from
ef99da9 to
186bdae
Compare
…locks or All Double mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using this test image
With the current behaviour of MapArtCraft, with Valley staircasing and All Blocks or All Double mode, the result will contain this weird overhang:
All Blocks Mode (wool):
All Blocks Mode (carpet):
All Double Mode:
which is caused by the valley mode's "pull down". This behaviour will occur only with a plateau of length 2 or more, as seen below.
This pull request will ignore those weird overhangs, and adjust the block count accordingly only when using the valley mode.