Skip to content

Prevent resuming a session that has not been fully shut down#7160

Draft
jbreams wants to merge 16 commits intomasterfrom
jbr/reconnect_during_error
Draft

Prevent resuming a session that has not been fully shut down#7160
jbreams wants to merge 16 commits intomasterfrom
jbr/reconnect_during_error

Conversation

@jbreams
Copy link
Copy Markdown
Contributor

@jbreams jbreams commented Nov 21, 2023

What, How & Why?

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@coveralls-official
Copy link
Copy Markdown

coveralls-official Bot commented Nov 21, 2023

Pull Request Test Coverage Report for Build jonathan.reams_2947

  • 315 of 349 (90.26%) changed or added relevant lines in 14 files are covered.
  • 80 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.04%) to 91.739%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/realm/object-store/c_api/sync.cpp 0 2 0.0%
src/realm/sync/client.cpp 11 13 84.62%
src/realm/sync/protocol.hpp 0 2 0.0%
test/object-store/sync/flx_sync.cpp 183 187 97.86%
src/realm/object-store/sync/sync_session.cpp 69 79 87.34%
src/realm/sync/noinst/client_impl_base.cpp 23 37 62.16%
Files with Coverage Reduction New Missed Lines %
src/realm/object-store/c_api/sync.cpp 1 55.41%
test/util/compare_groups.cpp 1 54.74%
src/realm/sync/network/websocket.cpp 2 74.44%
src/realm/sync/noinst/client_impl_base.hpp 2 93.62%
src/realm/sync/protocol.hpp 2 71.13%
test/test_lang_bind_helper.cpp 2 93.3%
src/realm/sort_descriptor.cpp 3 93.7%
src/realm/sync/network/network.cpp 3 89.86%
src/realm/sync/noinst/client_impl_base.cpp 3 85.74%
src/realm/query_expression.hpp 4 93.59%
Totals Coverage Status
Change from base Build 1872: 0.04%
Covered Lines: 232137
Relevant Lines: 253041

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant