Builds: Rename "External" version type to "Pull request" in UI and docs#13098
Open
ericholscher wants to merge 2 commits into
Open
Builds: Rename "External" version type to "Pull request" in UI and docs#13098ericholscher wants to merge 2 commits into
ericholscher wants to merge 2 commits into
Conversation
Reverts the terminology change from #13090 and updates the version type label from "External" (an internal code name) to "Pull request" which is the user-facing marketing name, per the style guide. https://claude.ai/code/session_012wqprntUMuLqGGNskCFMxJ
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates public-facing terminology so the internal version type name “External” no longer appears in the UI or user documentation, replacing it with the user-facing label “Pull request”.
Changes:
- Update the
externalversion type display label to “Pull request” viaEXTERNAL_TEXTinreadthedocs/builds/constants.py. - Add Django migrations to update frozen field
choicesfor version-type fields so the admin/model state reflects the new label. - Update automation rules documentation to use “Pull request” terminology instead of “External”.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| readthedocs/projects/migrations/0165_alter_automationrulematch_version_type.py | Updates frozen choices label for projects.AutomationRuleMatch.version_type to “Pull request”. |
| readthedocs/builds/migrations/0073_alter_automationrulematch_version_type_and_more.py | Updates frozen choices labels for several builds app fields using the external version type. |
| readthedocs/builds/constants.py | Changes the user-facing label for external from “External” to “Pull request”. |
| docs/user/automation-rules.rst | Replaces “External” with “Pull request” in user docs for automation rules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version type label "External" is an internal code name that leaked into
the UI and docs. The style guide says to use the marketing name in
public-facing surfaces — "Pull request" is what users know this concept as.
This reverts the docs terminology change from #13090 and updates the
Django model choice label from
_("External")to_("Pull request")inbuilds/constants.py, so the UI (automation rules form, version typedropdowns, etc.) now shows "Pull request" instead of "External".
Related: #13090
Generated by Claude Code
Generated by Claude Code