Use django-debug-toolbar cache backend to share data across workers#13087
Use django-debug-toolbar cache backend to share data across workers#13087agjohnson wants to merge 1 commit into
Conversation
This resolves the bug where loading a pane in debug toolbar give an error about not being able to load the data. Because gunicorn is running with multiple workers, the local memory backend doesn't work.
agjohnson
force-pushed
the
agj/debug-toolbar-cache
branch
from
cfafe97 to
744b1c1
Compare
| # It's a "known issue/bug" and there is no solution as far as we can tell. | ||
| # Panels that are slow | ||
| "debug_toolbar.panels.sql.SQLPanel", | ||
| "debug_toolbar.panels.templates.TemplatesPanel", |
There was a problem hiding this comment.
Is this just unchecking the panel by default or is it removing it?
There was a problem hiding this comment.
We are re-enabling it now. @agjohnson is that what we want here? why did you change this config? does it work reliably now?
There was a problem hiding this comment.
@stsewd only disables it by default. You have to click on it to enable it.
There was a problem hiding this comment.
I don't trust the comment in settings is at all accurate. The templates pane works fine and I'm fixing up debug toolbar specifically for that pane. It's much better than trying to guess what templates are used by deciphering HTML.
There was a problem hiding this comment.
I remember having a bunch of issues with that pane and disabling it worked.
I'm fine re-enabling it if it works, but honestly, I don't think it has to be enabled by default. 99% of the time we don't look at that pane. Also, once you enable it locally it saves a cookie in your browser, so it will be enabled by default for you.
I'd prefer to keep it disabled by default.
There was a problem hiding this comment.
Yes, the pane works fine for me. If you don't recall the errors that you've hit, I think it's safe to just keep it enabled.
The only error I've encountered is the error fixed by this PR. I was using the single worker fix for months prior to this to use the toolbar.
I mostly want to make this more usable. After watching Eric struggle to debug templates, it's pretty clear this needs to be a more obvious it's part of our development workflow.
humitos
left a comment
humitos
left a comment
There was a problem hiding this comment.
This is a way better solution if it works.
I tested this locally and it worked. I'm curious why this does work in production without requiring this setting, tho 🤔
| # It's a "known issue/bug" and there is no solution as far as we can tell. | ||
| # Panels that are slow | ||
| "debug_toolbar.panels.sql.SQLPanel", | ||
| "debug_toolbar.panels.templates.TemplatesPanel", |
There was a problem hiding this comment.
We are re-enabling it now. @agjohnson is that what we want here? why did you change this config? does it work reliably now?
| # It's a "known issue/bug" and there is no solution as far as we can tell. | ||
| # Panels that are slow | ||
| "debug_toolbar.panels.sql.SQLPanel", | ||
| "debug_toolbar.panels.templates.TemplatesPanel", |
There was a problem hiding this comment.
@stsewd only disables it by default. You have to click on it to enable it.
3 participants
This resolves the bug where loading a pane in debug toolbar give an
error about not being able to load the data. Because gunicorn is running
with multiple workers, the local memory backend doesn't work.