projects: make external_builds_enabled default to True#13039
Draft
Copilot wants to merge 1 commit into
Draft
Conversation
Agent-Logs-Url: https://github.com/readthedocs/readthedocs.org/sessions/fe8ea065-e33a-449a-8972-6d2014e08ec1 Co-authored-by: stsewd <4975310+stsewd@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
stsewd
May 12, 2026 19:54
View session
stsewd
approved these changes
May 12, 2026
Member
|
I think this is a good default since it's a super powerful feature. However, how much impact it would be in our costs? Won't it be pretty high? Also, if the user doesn't even use them it's just a lot of money wasted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the request to make
external_builds_enableddefault toTruefor new projects.Summary
external_builds_enabledfield default fromFalsetoTrueinreadthedocs/projects/models.py0165_external_builds_enabled_default_trueto update the database default for bothprojectandhistoricalprojecttablesNew projects will now have pull request builds enabled by default.
Generated by GitHub Copilot