Replace URL text filter with dropdown selection in redirects#13010
Replace URL text filter with dropdown selection in redirects#13010ericholscher wants to merge 4 commits into
Conversation
Mirror the version filter pattern in RedirectListFilterSet so the URL filter is a searchable model choice dropdown instead of a free-text icontains field. Generated by AI.
Generated by AI.
stsewd
left a comment
stsewd
left a comment
There was a problem hiding this comment.
This is exposing a URL filter, but than using the PK to do the actual filtering.
|
This still solves the problem, so seems better than the current state? |
Addresses review feedback: the filter is labeled "URL" so the URL parameter should also be a URL, not a primary key. Generated by AI.
|
Yeah I agree with @stsewd, we should keep the patterns on filters consistent. The code looks close now though, but it would be good to add visual proof of this change here. This branch throws an exception for me locally because my migrations are ahead of this branch. |
agjohnson
left a comment
agjohnson
left a comment
There was a problem hiding this comment.
Tentative +1, still need to see what this looks like.
But the code looks about what I'd expect and more closely matches the patterns we've used on all other filters now.
…ts-url-filter-ThC5x
This is how it looks locally now. I worry a little bit about including the URL in the URL, which could lead to some encoding weirdness or security issues, but hopefully it's fine? |
4 participants
Summary
Changed the redirect URL filter from a text-based search field to a dropdown selection using
FilteredModelChoiceFilter. This provides a more structured way to filter redirects by selecting specific redirect objects rather than searching by URL substring.Implementation Details
label_attribute="from_url"to display thefrom_urlfield in the dropdownto_field_name="pk"ensures filtering is done by the redirect's primary keyhttps://claude.ai/code/session_01E11C1jDS4cAwiCY6t6oN2k