build: update nuget package dependencies - #4426
Merged
Merged
Conversation
- Bump the Sharp analyzer suite 3.38.1 -> 3.40.1. - Bump the third-party C# analyzer package to its current release. - Bump TUnit 1.61.38 -> 1.63.0 and Microsoft.Testing.Platform.MSBuild 2.3.2 -> 2.3.3. - Framework-aligned pins are unchanged; each is already newest in its own major.minor band.
- SST1537 and SST1515 both fire on a comment sitting between '=>' and its expression, and SST2275 blocks the obvious block-body escape. - Fold the substantive explanations into <remarks> on the member's XML docs. - Drop bare "Act & Assert" markers from single-expression tests; they add nothing.
- Wine does not enforce WPF Dispatcher thread affinity, so its results were never trustworthy for the tests that most needed a Windows host. - Windows verification belongs on CI, or a real Windows guest.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4426 +/- ##
=======================================
Coverage 93.35% 93.35%
=======================================
Files 347 347
Lines 14921 14921
Branches 1553 1553
=======================================
Hits 13929 13929
Misses 731 731
Partials 261 261 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What kind of change does this PR introduce?
Build (dependency updates), plus the analyzer fallout they caused and one docs removal.
What is the new behavior?
PackageVersioninsrc/Directory.Packages.propsandsrc/benchmarks/Directory.Packages.propswas checked against nuget.org:=>and its expression. Those comments have moved:<remarks>on the member's XML docs, where they are actually discoverable.Act & Assertmarkers on single-expression tests are gone; they restated the one line beneath them.CLAUDE.mdno longer documents running the Windows test suites through Wine.What is the current behavior?
CLAUDE.mdtold agents to run WPF and WinForms tests under Wine on Linux. Wine does not enforce WPFDispatcherthread affinity, so results for the marshalling and background-thread tests were not trustworthy in the one place a Windows host mattered most.What might this PR break?
CLAUDE.md.AspNetVersionper TFM,MicrosoftExtensionsVersionandSystemTextJsonVersionare each already the newest release inside their own major.minor band, so bumping them to the newest overall version would have broken TFM alignment.Checklist
mainbranchAdditional information
Version discovery was done with a throwaway single-file
dotnet runtool built onNuGet.Protocol, queryingFindPackageByIdResource.GetAllVersionsAsyncfor every declared package. It resolves$(Property)indirections back to theirPropertyGroupdefinitions and compares each conditional value inside its own major.minor band, so TFM-aligned pins are not reported as stale against an unrelated major.Verified on Linux:
dotnet build reactiveui.slnx -c Release -t:Rebuild- 0 warnings, 0 errors. This includes the Windows target frameworks, which compile here viaEnableWindowsTargeting.Not verified locally, left to CI on
windows-latest: execution of the WPF, WinForms and WinUI suites.ReactiveUI.NonParallel.Mobile.Testsalso needs iOS workloads that are not installed on this machine.