Revert "Unbreak android CI by moving to ubuntu-latest (#57216)"#57323
Closed
cortinico wants to merge 1 commit into
Closed
Revert "Unbreak android CI by moving to ubuntu-latest (#57216)"#57323cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
This reverts the runner changes from #57216, moving the Android CI jobs back from `ubuntu-latest` to the dedicated `4-core-ubuntu` / `8-core-ubuntu` runners. Goal: measure whether the dedicated runners speed up RN's CI compared to `ubuntu-latest`. Note: `nightly.yml` was deleted and `publish-npm.yml` was restructured on main since #57216 landed, so those two files are intentionally left untouched; this revert only covers the per-PR CI jobs.
meta-cla
Bot
added
the
CLA Signed
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D109808150. |
|
@cortinico merged this pull request in 19c11ba. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This reverts the runner changes from #57216, which moved the Android CI jobs from the dedicated
4-core-ubuntu/8-core-ubunturunners onto the standardubuntu-latestrunners.I'm opening this (as a draft) to see if we can speed up the RN runners — i.e. to measure whether going back to the larger dedicated runners gives us faster CI than
ubuntu-latest. This is an experiment to compare timings.What's reverted
e2e-android-rntester.yml:ubuntu-latest→4-core-ubuntue2e-android-templateapp.yml:ubuntu-latest→4-core-ubuntufantom-tests.yml:ubuntu-latest→8-core-ubuntutest-all.yml:build_fantom_runner,build_android,build_npm_package→8-core-ubuntu;test_android_helloworld→4-core-ubuntuNot reverted (drift since #57216)
nightly.ymlwas deleted on main (consolidated intopublish-npm.yml).publish-npm.ymlwas fully restructured on main (the oldpublish-react-nativereusable job no longer exists).These two are release/nightly jobs rather than the per-PR CI that determines runner speed, so they're intentionally left untouched.
Changelog:
[INTERNAL] -
Changelog
[INTERNAL] -
Test Plan
CI — compare job durations against
ubuntu-latest.