Skip to content

refactor: use renderable guards for overflow adornments #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yoyo837 merged 2 commits into from
Sep 3, 2026
+26 −5
Merged

refactor: use renderable guards for overflow adornments #71

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d0f9b9
refactor: use renderable guards
QDyanbing Sep 3, 2026
f4578ab
fix: handle numeric suffix layout
QDyanbing Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"dependencies": {
"@babel/runtime": "^8.0.0",
"@rc-component/resize-observer": "^1.0.1",
"@rc-component/util": "^1.11.1",
"@rc-component/util": "^1.13.0",
"clsx": "^2.1.1"
},
"devDependencies": {
Expand Down
6 changes: 3 additions & 3 deletions src/Overflow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as React from 'react';
import { useState, useMemo, useCallback } from 'react';
import { clsx } from 'clsx';
import ResizeObserver from '@rc-component/resize-observer';
import { useLayoutEffect } from '@rc-component/util';
import { isReactRenderable, useLayoutEffect } from '@rc-component/util';
import Item from './Item';
import useEffectState, { useBatcher } from './hooks/useEffectState';
import type { ComponentType } from './RawItem';
Expand Down Expand Up @@ -401,7 +401,7 @@ function Overflow<ItemType = any>(
{...restProps}
>
{/* Prefix Node */}
{prefix && (
{isReactRenderable(prefix) && (
<Item
{...itemSharedProps}
responsive={isResponsive}
Expand All @@ -421,7 +421,7 @@ function Overflow<ItemType = any>(
{showRest ? restNode : null}

{/* Suffix Node */}
{suffix && (
{isReactRenderable(suffix) && (
Comment thread
coderabbitai[bot] marked this conversation as resolved.
<Item
{...itemSharedProps}
responsive={isResponsive}
Expand Down
Loading