Remove using namespace std from Python - #1473
Draft
cielavenir wants to merge 2 commits into
Draft
Conversation
cielavenir
marked this pull request as draft
November 26, 2024 12:00
Collaborator
Author
|
controllercommon etc's python bindings replies on |
Collaborator
Author
|
@felixvd @hemangandhi could you fix mujin (controllercommon etc) compilation with this MR? |
Collaborator
|
https://tiny.mujin.co.jp/or-1473-internal-test -- the internal changes needed for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openrave_int.h is a public header of python binding, so
using namespace std;should not be used.