Add virtual destructors - #1463
Open
lazydroid wants to merge 8 commits into
Open
Conversation
Collaborator
|
likely I have to take over this pull request cc @florisatmujin @pico737 @rolandjitsu @yoshikikanemoto |
cielavenir
force-pushed
the
dev/lenik/add_virtual_destructors
branch
from
June 15, 2026 06:39
d655661 to
1269c2d
Compare
Collaborator
|
Please see detectorcontainers!329 for why I started to need this pull request edit: I changed detectorcontainers' include_directory(OpenRAVE) to SYSTEM, so not hard requirement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add virtual destructors to the classes that have virtual members to prevent improper destruction and possible memory leaks.