Skip to content

Fix Louvain bug introduced in new threshold logic#5549

Merged
rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
ChuckHastings:debug_louvain
Jun 10, 2026
Merged

Fix Louvain bug introduced in new threshold logic#5549
rapids-bot[bot] merged 1 commit into
rapidsai:mainfrom
ChuckHastings:debug_louvain

Conversation

@ChuckHastings

@ChuckHastings ChuckHastings commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

#5541 introduced a bug that wasn't detectable in the small test graphs.

Adjust delta modularity from last commit to be scaled based on graph size. Previously the threshold was treated as an absolute, but the delta modularity is a function of the number of vertices in the graph.

Closes #5516

@copy-pr-bot

copy-pr-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@ChuckHastings ChuckHastings added bug Something isn't working non-breaking Non-breaking change labels Jun 9, 2026
@ChuckHastings ChuckHastings marked this pull request as ready for review June 9, 2026 04:33
@ChuckHastings ChuckHastings requested a review from a team as a code owner June 9, 2026 04:33

@seunghwak seunghwak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChuckHastings

Copy link
Copy Markdown
Collaborator Author

/merge

@rapids-bot rapids-bot Bot merged commit 661f5eb into rapidsai:main Jun 10, 2026
208 of 212 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEA]: Non-deterministic behavior from Louvain due to numerical instability

2 participants