fix: always store elemental.cattle.io/os.unmanaged regardless of labe… - #1025
Draft
aeltai wants to merge 1 commit into
Draft
fix: always store elemental.cattle.io/os.unmanaged regardless of labe…#1025aeltai wants to merge 1 commit into
aeltai wants to merge 1 commit into
Conversation
…lPrefix The os.unmanaged annotation is an operator-internal signal used by the reset controller. It must always be stored under the well-known elemental.cattle.io/os.unmanaged key, independent of MachineRegistration labelPrefix. Previously, labelPrefix: "-" would store it as plain "os.unmanaged", causing the reset controller to issue the wrong (toolkit) reset plan. Fixes: rancher#1023 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lPrefix
The os.unmanaged annotation is an operator-internal signal used by the reset controller. It must always be stored under the well-known elemental.cattle.io/os.unmanaged key, independent of MachineRegistration labelPrefix. Previously, labelPrefix: "-" would store it as plain "os.unmanaged", causing the reset controller to issue the wrong (toolkit) reset plan.
Fixes: #1023