Skip to content

Add instrument landing pages #1779#1960

Open
louise-davies wants to merge 3 commits into
developfrom
instrument-landing-pages-#1779
Open

Add instrument landing pages #1779#1960
louise-davies wants to merge 3 commits into
developfrom
instrument-landing-pages-#1779

Conversation

@louise-davies

Copy link
Copy Markdown
Member

Description

Add instrument landing pages. I made them generic so they can be used for both ISIS and DLS - to do this I made the branding component generic, and made a config option to configure the logo. It can either be a custom logo by providing a path via a string or STFC or DLS will render the STFC or DLS logos respectively (aka old branding component behaviour).

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • Test instrument landing pages work. Maybe test with ISIS dev to test PID rendering works (and soon start/end dates should work once I add them to ISIS dev)

Agile board tracking

Closes #1779

- make branding component generic via a config option to specify the logo
…ding page tests to account for branding changes
@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.34641% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.73%. Comparing base (4cbfd83) to head (306a9cf).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...s/datagateway-dataview/src/state/actions/index.tsx 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #1960    +/-   ##
=========================================
  Coverage    96.72%   96.73%            
=========================================
  Files          220      221     +1     
  Lines        31297    31442   +145     
  Branches      4707     4741    +34     
=========================================
+ Hits         30271    30414   +143     
  Misses        1023     1023            
- Partials         3        5     +2     
Flag Coverage Δ
common 95.48% <ø> (ø)
dataview 98.49% <99.34%> (+<0.01%) ⬆️
download 96.92% <ø> (ø)
search 95.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add instrument landing pages

1 participant