Upgrade React Router #1110#1896
Open
louise-davies wants to merge 10 commits into
Open
Conversation
- still a WIP, just got dataview to run properly
- fix multiple query bug with checking default sorts/filters are set before querying
- these tests fail when run with other test suites
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## react-query-5 #1896 +/- ##
==============================================
Coverage 96.78% 96.78%
==============================================
Files 219 221 +2
Lines 30906 30909 +3
Branches 4587 4615 +28
==============================================
+ Hits 29911 29916 +5
+ Misses 990 988 -2
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…fix some e2e tests
- either stop removing the default sort where is not needed any more and instead just test the column we're trying to sort is sorted - or add some checks to ensure the default sort is actually applied before continuing the test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Biggest refactors are:
datagateway-dataviewso thatPageRoutingis the "top level" component that gets imported viaApp, andPageContainerbecomes a "layout route" that usesOutletto render the actual route contents andmatchPathto turn on/off different UI elementsTableand instead just link/route with the default params provided - but that's a larger refactor I didn't want to mix up in hereOtherwise just "standard" refactoring as according to the migration guides
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
Closes #1110