Migrate to React Query 5#1880
Open
louise-davies wants to merge 5 commits into
Open
Conversation
- fixed all errors - started fixing unit tests - started refactoring to use skip/limit directly as page params in infinite queries
…seMutations to align more with current docs
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1880 +/- ##
===========================================
+ Coverage 96.70% 96.78% +0.07%
===========================================
Files 219 219
Lines 30938 30906 -32
Branches 4616 4587 -29
===========================================
- Hits 29919 29911 -8
+ Misses 1015 990 -25
- Partials 4 5 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshdimanteto
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
See title. Main breaking changes were the changes to
useInfiniteQuery, the removal ofexact: falsetosetQueryData/getQueryDataand thus having to usesetQueriesData/getQueriesData, removing onError handlers and instead using query meta and a global error handler i nthe query cache, some changes touseMutation, renamingloadingstate topendingandisInitialLoadingtoisLoading.Plus I added the eslint plugin for react query so fixing a lot of things there, mostly because URLs were not in query keys. We could just ignore these errors, but that means we don't get the full power of the linter, and in most cases added them to the query key is fine. It makes finding exact query keys harder but I think I've worked around it sufficiently. Due to adding the linter I based this branch off of the eslint branch.
Testing instructions
Add a set up instructions describing how the reviewer should test the code