fix: keep the theme root from affecting layout - #2693
Open
SnowingFox wants to merge 1 commit into
Open
Conversation
1 task
|
@SnowingFox is attempting to deploy a commit to the rainbowdotme Team on Vercel. A member of the Team first needs to authorize it. |
馃 Changeset detectedLatest commit: 50dd957 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RainbowKitProviderinjects a theme-root<div data-rk>wrapper around its children so its scoped theme CSS variables can be applied. Because that injected<div>is an unstyled block element, it participates in layout: a full-height page that relies onheight: 100%(or flex) stretching no longer fills the screen, since the extra wrapper breaks theheightchain.See #2164
Root cause
The theme root is rendered as a plain
<div {...createThemeRootProps(id)}>with no layout behavior. It generates a normal block box, so children that depend onheight: 100%stretching no longer fill their parent.Fix
Give the theme-root wrapper
style={{ display: 'contents' }}. The element no longer generates a layout box, so children render exactly as if the wrapper were not there, while thedata-rkattribute is preserved. The scoped theme still works because the[data-rk]selector only sets CSS custom properties (viacssObjectFromTheme/assignInlineVars), which are inherited by children regardless of the wrapper's box.Test
Adds a component test (
RainbowKitProvider.test.tsx) that renders the provider and asserts the injected theme-root element still carries thedata-rkattribute and hasdisplay: contents, so it cannot affect layout. The test fails on the previous behavior (the wrapper is a plain block<div>) and passes with the fix.Fixes #2164