-
Notifications
You must be signed in to change notification settings - Fork 793
feat: add Vultisig wallet #2692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
realpaaao
wants to merge
2
commits into
rainbow-me:main
Choose a base branch
from
realpaaao:add-vultisig-wallet
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@rainbow-me/rainbowkit": patch | ||
| --- | ||
|
|
||
| Added Vultisig wallet support with the `vultisigWallet` wallet connector. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
packages/rainbowkit/src/wallets/walletConnectors/vultisigWallet/vultisigWallet.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
44 changes: 44 additions & 0 deletions
44
packages/rainbowkit/src/wallets/walletConnectors/vultisigWallet/vultisigWallet.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import { | ||
| getInjectedConnector, | ||
| hasInjectedProvider, | ||
| } from '../../getInjectedConnector'; | ||
| import type { Wallet } from '../../Wallet'; | ||
|
|
||
| export const vultisigWallet = (): Wallet => ({ | ||
| id: 'vultisig', | ||
| name: 'Vultisig', | ||
| rdns: 'me.vultisig', | ||
| iconUrl: async () => (await import('./vultisigWallet.svg')).default, | ||
| iconBackground: '#061B3A', | ||
| installed: hasInjectedProvider({ namespace: 'vultisig.ethereum' }), | ||
| downloadUrls: { | ||
| chrome: | ||
| 'https://chromewebstore.google.com/detail/vultisig-extension/ggafhcdaplkhmmnlbfjpnnkepdfjaelb', | ||
| firefox: | ||
| 'https://addons.mozilla.org/en-US/firefox/addon/vultisig-extension/', | ||
| browserExtension: 'https://vultisig.com/downloads', | ||
| }, | ||
| extension: { | ||
| instructions: { | ||
| learnMoreUrl: 'https://docs.vultisig.com', | ||
| steps: [ | ||
| { | ||
| description: 'wallet_connectors.vultisig.extension.step1.description', | ||
| step: 'install', | ||
| title: 'wallet_connectors.vultisig.extension.step1.title', | ||
| }, | ||
| { | ||
| description: 'wallet_connectors.vultisig.extension.step2.description', | ||
| step: 'create', | ||
| title: 'wallet_connectors.vultisig.extension.step2.title', | ||
| }, | ||
| { | ||
| description: 'wallet_connectors.vultisig.extension.step3.description', | ||
| step: 'refresh', | ||
| title: 'wallet_connectors.vultisig.extension.step3.title', | ||
| }, | ||
| ], | ||
| }, | ||
| }, | ||
| createConnector: getInjectedConnector({ namespace: 'vultisig.ethereum' }), | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the Vultisig extension is installed, its EVM provider is also exposed as the MetaMask-compatible
window.ethereumwithisMetaMask: true, so adding this connector without also excludingwindow.vultisig.ethereumfrommetaMaskWalletleaves dApps that include both wallets (including the updated example/default MetaMask setup) showing MetaMask as installed and routing MetaMask clicks into the Vultisig provider. Please update the MetaMask impersonation filter alongside this connector so Vultisig users only get the Vultisig option.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch — addressed in f42b519. The Vultisig EVM provider ships a distinguishing flag in every released extension version (
isVultiConnect: true, from the extension's original name), so the impersonation filter now excludes onethereum.isVultiConnect || ethereum.isVultisig— the second flag is forward-compatible with the extension's rename to "Vultisig Extension". With this, machines with only Vultisig installed no longer show MetaMask as installed, and MetaMask clicks no longer route into the Vultisig provider.