Validations: Default context based on persistence#469
Open
seanpdoyle wants to merge 2 commits into
Open
Conversation
seanpdoyle
force-pushed
the
validates-default-context
branch
from
92ac827 to
a4ef2aa
Compare
seanpdoyle
force-pushed
the
validates-default-context
branch
from
a4ef2aa to
0b682b2
Compare
Forward the `:context` option from `Base#save` and `Base#save!` to the underlying `Validations#valid?` call. The argument delegation changes to this method signature are necessary for the sake of the [ActiveResource::Validations#save_with_validation][] method. The `ActiveResource::Validations` module aliases the previously defined `#save` method to a `#save_without_validation` method, and then defines its own `#save_with_validation` method which accepts arguments (previously the `:validate` option, now the `:validate` *and* `:context` option). This commit also includes test coverage for directly calling `Validations#valid?` with a `context` value, since that behavior wasn't covered by tests elsewhere in the suite. [ActiveResource::Validations#save_with_validation]: https://github.com/rails/activeresource/blob/v6.2.0/lib/active_resource/validations.rb#L111
This commit proposed that Active Resource follow the same pattern as [Active Record Validations][], namely that an instance's default validation context will be `:create` when the record **is not yet** persisted and `:update` when the record **is** persisted. [Active Record Validations]: https://api.rubyonrails.org/v8.1/classes/ActiveRecord/Validations.html#method-i-valid-3F
seanpdoyle
force-pushed
the
validates-default-context
branch
from
0b682b2 to
dbfae0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #468
This commit proposed that Active Resource follow the same pattern as
Active Record Validations, namely that an instance's default
validation context will be
:createwhen the record is not yetpersisted and
:updatewhen the record is persisted.