feat: improve Makefile#7
Open
LZhaoM wants to merge 1 commit into
Open
Conversation
16dc863 to
f396bb4
Compare
RadxaYuntian
reviewed
Sep 5, 2025
Member
RadxaYuntian
left a comment
There was a problem hiding this comment.
用?=就是为了可以在调用make的时候传入自己定义的变量值啊,你现在就必须去改文件了
Collaborator
Author
|
主要是感觉这样Simple and Stupid一些, |
Member
|
|
Member
|
原本的readme也都是给c200准备的,你要改的话就把readme还有比如默认路径都改了 |
Collaborator
Author
默认路径指的是什么? |
Member
|
默认路径指的是makefile里面很多写死的c200 |
Member
|
另外现在既然没有默认值可用,readme还要准备一个表格,用于告诉用户哪个产品哪个核心板用什么参数配置 |
9d77618 to
3493d1e
Compare
Requiring setting the variables before building can avoid the situation that, in the first time building, the default configurations are not what users want. Some paths are hardcoded with c200/*. Now this repo supports both Airbox Orin and C200, we should use the PRODUCT variable to replace the hardcoded part of the paths. For consistency, README is updated to introduce the possible values of PRODUCT and BOARDSKU. Signed-off-by: Zhaoming Luo <luozhaoming@radxa.com>
3493d1e to
52f177e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.